[FIXED] 1.0.8 :: Contact component dropdown not populated

latristesse · **Joined:** Mon Dec 12, 2005 9:59 pm **Posts:** 248

I'm not sure if this is where I post a problem with the new release or not. I just upgraded and everything looks good so far except for the drop-down in the contact module - it's not populating anymore. All the contacts are in the index, but they don't show up in the drop-down. The drop-down was fine in 1.0.7.

latristesse · **Joined:** Mon Dec 12, 2005 9:59 pm **Posts:** 248

I just upgraded from 1.0.7 to 1.0.8. The contacts drop-down on the front-end is no longer populating. This worked in 1.0.7 but is now broken on both IE and Firefox. The drop-down is there, but it has no information in it. All of the contacts have "Show" selected on the Drop-down parameter.

Here is the relevant output I see when I look at the HTML source:

Code:

<script type="text/javascript">
      <!--
      function ViewCrossReference( selSelectObject ){
         var links = new Array();
         
         var sel = selSelectObject.options[selSelectObject.selectedIndex].value
         if (sel != "") {
            location.href = links[sel];
         }
      }
      //-->
      </script>
      
      <table width="100%" cellpadding="0" cellspacing="0" border="0" class="contentpane">
               <tr>
            <td colspan="2" align="center">
            <br />

            <form action="testserverURL/component/option,com_contact/Itemid,130/" method="post" name="selectForm" target="_top" id="selectForm">
               Select Contact:               <br />
               
<select name="contact_id" class="inputbox" onchange="ViewCrossReference(this);">
</select>
            </form>
            </td>
         </tr>

latristesse · **Joined:** Mon Dec 12, 2005 9:59 pm **Posts:** 248

I think my issue about the contact drop-down has gotten buried here...

was_nun? · **Joined:** Fri Aug 19, 2005 4:58 am **Posts:** 25

I reported this in another threat... I hope this is the right place now.

Hi there!

I upgraded from 1.0.7 to 1.0.8 just now. Everything works fine except for one thing. When I open my contact section there used to be a dropdown menu to show all entries. Well, the menu is still there, but it became very small and it is empty although there are serveral entries in the backend... and ideas how to solve this small problem?

Thanks for your great work on joomla!

Cheers!

was_nun?

Btw a second user reported a similar thing here:

latristesse wrote:

I'm not sure if this is where I post a problem with the new release or not. I just upgraded and everything looks good so far except for the drop-down in the contact module - it's not populating anymore. All the contacts are in the index, but they don't show up in the drop-down. The drop-down was fine in 1.0.7.

X-Dimension · **Joined:** Thu Sep 15, 2005 9:31 am **Posts:** 96

Same Problem here

XD

usk · **Joined:** Wed Feb 15, 2006 11:53 am **Posts:** 69

Same here.

mic · **Posted:** Tue Feb 28, 2006 7:25 pm

Guess somebody of the Q&A team forgot something ;-)

Change this part:

Code:

foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access > $my->gid ) {
            $list[] = $check;
         }
      }

into

Code:

foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access >= $my->gid ) {
            $list[] = $check;
         }
      }

and you will have your list ...
The missing part ist the = between cat_access > and $my->gid

You will find this part around line 233 in the ../components/com_contact/contact.php.

michael

latristesse · **Joined:** Mon Dec 12, 2005 9:59 pm **Posts:** 248

This did the trick...thanks!

was_nun? · **Joined:** Fri Aug 19, 2005 4:58 am **Posts:** 25

works like magic - thanks a bunch! :-*

was_nun?

infograf768 · **Posted:** Tue Mar 07, 2006 3:36 pm

This looks like solved in SVN.

stingrey · **Posted:** Wed Mar 08, 2006 10:03 am

Fixed in SVN

pastor_rob · **Posted:** Sun Mar 12, 2006 6:03 am

stingrey wrote:

Fixed in SVN

What is SVN??? And how do we get it?

divivo · **Joined:** Thu Jan 05, 2006 3:53 pm **Posts:** 68

I still have a problem with this. When i am logged in with a regsitrered user, the drop down disappear again. When I am not logged in it is all working fine. Any idea?

To make sure I did a fresh test install of Joomla 1.0.8 and it is the same. The only thing I have installed is CB.

pe7er · **Posted:** Sun Mar 19, 2006 11:28 pm

pastor_rob wrote:

What is SVN??? And how do we get it?

Here you can read more about SVN: http://forum.joomla.org/index.php/topic,47386.0.html

Teasel · **Joined:** Wed Mar 22, 2006 12:36 am **Posts:** 3

mic wrote:

Guess somebody of the Q&A team forgot something ;-)

Change this part:

Code:

foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access > $my->gid ) {
            $list[] = $check;
         }
      }

into

Code:

foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access >= $my->gid ) {
            $list[] = $check;
         }
      }

and you will have your list ...
The missing part ist the = between cat_access > and $my->gid

You will find this part around line 233 in the ../components/com_contact/contact.php.

michael

Ummm, I may be missing something, but surely the above comparator should be changed to <= (Add the contact to the list only if it's the same as, or less private, than the current gid).

Wouldn't your suggested alteration (and the existing code) mean that registered users couldn't see public categories, but they could see special categories?

Of course, I'm just a newbie, so feel free to flame me if I'm showing my inexperience!!! (Or chalk up another security fix if I'm right!)

stingrey · **Posted:** Wed Mar 29, 2006 7:43 am

http://forum.joomla.org/index.php/topic,47039.0.html

Teasel · **Joined:** Wed Mar 22, 2006 12:36 am **Posts:** 3

The file attached to that thread appears to have the alteration suggested by mic. I believe that his suggestion both fails to completely fix the problem and also introduces a security hole. For this reason I will not be installing that patch and I urge you to do some proper testing to convince yourself that I am indeed talking bullshit before you include that code in 1.0.9!

stingrey · **Posted:** Thu Mar 30, 2006 2:09 pm

Teasel wrote:

The file attached to that thread appears to have the alteration suggested by mic. I believe that his suggestion both fails to completely fix the problem and also introduces a security hole. For this reason I will not be installing that patch and I urge you to do some proper testing to convince yourself that I am indeed talking ******** before you include that code in 1.0.9! ;)

You are acutally correct in that the access logic check is incorrect.

However, as it turns out, the check is not even needed.
And even with the incorrect logic, this does not introduce a security hole into the system.

This is because the values being populated can only be from the same category as the one you are viewing currently, as seen in the first part of the logic check:

Code:

$check->catid == $contact->catid

So the fact you can even view the contact item of this category means you have sufficient access to view other contact items in that same category.

It is unnecessary to once again check if you have sufficient access rights to view the items of the particular category you are viewing.

Teasel · **Joined:** Wed Mar 22, 2006 12:36 am **Posts:** 3

Thanks stingrey, that makes sense! However... the file in the thread you linked to above still contains the following code:

Code:

      $list = array();
      foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access >= $my->gid ) {
            $list[] = $check;
         }
      }      

So, how will any public contacts ever be visible to a logged-in user? I suggested you change the >= to a <= You explained that actually the test isn't necessary at all. But surely leaving the incorrect test in the code is the worst possible approach?!

baskoenders · **Joined:** Mon May 01, 2006 12:58 pm **Posts:** 1

just did the last sugestion and that's works fine.
The >= solution results in no drop down for registred users.

pastor_rob · **Posted:** Mon May 01, 2006 2:21 pm

Teasel wrote:

Thanks stingrey, that makes sense! However... the file in the thread you linked to above still contains the following code:

Code:

      $list = array();
      foreach ( $checks as $check ) {
         if ( $check->catid == $contact->catid && $check->cat_access >= $my->gid ) {
            $list[] = $check;
         }
      }      

So, how will any public contacts ever be visible to a logged-in user? I suggested you change the >= to a <= You explained that actually the test isn't necessary at all. But surely leaving the incorrect test in the code is the worst possible approach?!

Once I did the corrected <= instead of >= ... the dropdown menu reappeared. Thanks to all for finally coming through on this.

yabba dabba · **Joined:** Fri Jan 27, 2006 4:03 pm **Posts:** 96

Ahh. NOW it works.

Apparently "<=" > ">="

Thanks for the unofficial mod to the semi-official mod to the broken but official release. (sheesh)

[FIXED] 1.0.8 :: Contact component dropdown not populated

Quick reply

Who is online