It is currently Sat Oct 11, 2008 6:30 pm

 

All times are UTC




Post new topic Reply to topic  [ 14 posts ] 
Author Message
 Post subject: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Tue Aug 29, 2006 12:44 pm 
Joomla! Fledgling
Joomla! Fledgling
Offline

Joined: Tue Aug 29, 2006 12:37 pm
Posts: 2
Description:
Bannerupload broken in Joomla 1.0.11. A direct upload through the button "upload" in the components toolbar is not possible because the popup re-sets the directory to ''.

Reported on:
1.0.11

Affected functions:
Bannerupload of com_banner

Related files:
administrator/popups/uploadimage.php

Steps to replicate:
Adminpanel, click components, banners, manage banners, upload. Try to upload an image and open it with the banner-management.

Proposed fix(es):
administrator/popup/uploadimage.php, line 75 following, change
Code:
if ( $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
   $directory    = '';
}
to
Code:
if ( $directory != 'banners' && $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
   $directory    = '';
}


System info:
Joomla! 1.0.11 Stable [ Sunbow ] 28 August 2006 20:00 UTC


Last edited by RobInk on Mon Oct 16, 2006 12:54 pm, edited 1 time in total.

Top
 Profile E-mail  
 
 Post subject: Re: Bannerupload broken
PostPosted: Tue Aug 29, 2006 12:49 pm 
User avatar
Joomla! Master
Joomla! Master
Online

Joined: Thu Aug 18, 2005 10:41 am
Posts: 14151
Location: The Netherlands
[TAGGED: Q&T] Status > Under Review

_________________
Regards Robin - Site & Infrastructure

Spilling the Beans on Open Source - Case studies, Reviews, Interviews and more @ http://robink.nl
1 Month, 1 Day http://robink.nl/2008/09/27/1-month-1-day/


Top
 Profile E-mail  
 
 Post subject: Re: [UNDER REVIEW: 1.0.11] Bannerupload broken
PostPosted: Tue Aug 29, 2006 1:17 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 10368
Location: •Translation Matters•
What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr · GMT +2
Qui vult dare parva non debet magna rogare.


Top
 Profile E-mail  
 
 Post subject: Re: [UNDER REVIEW: 1.0.11] Bannerupload broken
PostPosted: Tue Aug 29, 2006 1:24 pm 
Joomla! Fledgling
Joomla! Fledgling
Offline

Joined: Tue Aug 29, 2006 12:37 pm
Posts: 2
infograf768 wrote:
What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php
Yes, thats alright, I also get this. The check for directories is done before banners is described as a special case. So this second check always falses.


Top
 Profile E-mail  
 
 Post subject: Re: [UNDER REVIEW: 1.0.11] Bannerupload broken
PostPosted: Tue Aug 29, 2006 1:36 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 10368
Location: •Translation Matters•
@nico

I confirm your hack works. I don't know if it is asecurity problem though

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr · GMT +2
Qui vult dare parva non debet magna rogare.


Top
 Profile E-mail  
 
 Post subject: Re: [UNDER REVIEW: 1.0.11] Bannerupload broken
PostPosted: Tue Aug 29, 2006 1:49 pm 
User avatar
Joomla! Master
Joomla! Master
Online

Joined: Thu Aug 18, 2005 10:41 am
Posts: 14151
Location: The Netherlands
Bug tracker artifact added: http://forge.joomla.org/sf/go/artf5756?nav=1

_________________
Regards Robin - Site & Infrastructure

Spilling the Beans on Open Source - Case studies, Reviews, Interviews and more @ http://robink.nl
1 Month, 1 Day http://robink.nl/2008/09/27/1-month-1-day/


Top
 Profile E-mail  
 
 Post subject: Re: [ADDED TRACKER: 1.0.11] Bannerupload broken
PostPosted: Thu Aug 31, 2006 2:41 pm 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Wed Aug 17, 2005 10:12 pm
Posts: 1686
Location: Germany-Bad Abbach
Fixed in SVN

_________________
The "Humor, Fun and Games" forum has  more than 2500 Posts, so why not build a "Humor, Fun and Games Working" Group?
.....
Malicious tongues say we have this WG right from the start, they call it core team :D


Top
 Profile  
 
 Post subject: Re: [ADDED TRACKER: 1.0.11] Bannerupload broken
PostPosted: Thu Aug 31, 2006 8:23 pm 
User avatar
Joomla! Master
Joomla! Master
Online

Joined: Thu Aug 18, 2005 10:41 am
Posts: 14151
Location: The Netherlands
Hi,

I will be updating all Q&T topics tomorrow. I will add fixes to the known issue list as well.

Regards Robin

_________________
Regards Robin - Site & Infrastructure

Spilling the Beans on Open Source - Case studies, Reviews, Interviews and more @ http://robink.nl
1 Month, 1 Day http://robink.nl/2008/09/27/1-month-1-day/


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Mon Oct 16, 2006 12:55 pm 
User avatar
Joomla! Master
Joomla! Master
Online

Joined: Thu Aug 18, 2005 10:41 am
Posts: 14151
Location: The Netherlands
Artifact (http://forge.joomla.org/sf/go/artf5756?nav=1) has been fixed for next release, closing topic as FIXED, moving to Resolved.

_________________
Regards Robin - Site & Infrastructure

Spilling the Beans on Open Source - Case studies, Reviews, Interviews and more @ http://robink.nl
1 Month, 1 Day http://robink.nl/2008/09/27/1-month-1-day/


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Sun Aug 19, 2007 10:39 pm 
Joomla! Apprentice
Joomla! Apprentice
Offline

Joined: Fri Sep 02, 2005 11:15 pm
Posts: 35
I'm using  1.0.13 and the fix reported here above is in place in the uploadimage.php but it's still broken. When I try to upload a new image for a banner I get the following error:

Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator, webmaster@pizzaanyone.com and inform them of the time the error occurred, and anything you might have done that may have caused the error.

More information about this error may be available in the server error log.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

I've chmoded the directories to 777 but that didn't help. Any ideas??


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Sun Aug 26, 2007 6:54 pm 
User avatar
Joomla! Master
Joomla! Master
Online

Joined: Thu Aug 18, 2005 10:41 am
Posts: 14151
Location: The Netherlands
Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.

_________________
Regards Robin - Site & Infrastructure

Spilling the Beans on Open Source - Case studies, Reviews, Interviews and more @ http://robink.nl
1 Month, 1 Day http://robink.nl/2008/09/27/1-month-1-day/


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Sun Aug 26, 2007 11:09 pm 
Joomla! Apprentice
Joomla! Apprentice
Offline

Joined: Fri Sep 02, 2005 11:15 pm
Posts: 35
RobInk wrote:
Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.


Newbie here - how do I adjust the php memory?


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Mon Aug 27, 2007 6:24 am 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 10368
Location: •Translation Matters•
Jellocat wrote:
RobInk wrote:
Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.


Newbie here - how do I adjust the php memory?


Is'nt it through php.ini ?

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr · GMT +2
Qui vult dare parva non debet magna rogare.


Top
 Profile E-mail  
 
 Post subject: Re: [LOW:FIXED: 1.0.11] Bannerupload broken
PostPosted: Fri Oct 05, 2007 7:44 pm 
Joomla! Fledgling
Joomla! Fledgling
Offline

Joined: Fri Oct 05, 2007 7:31 pm
Posts: 2
php.ini:

In this section the runtime configuration parameters are examined in depth as far as phpWebSite is concerned.

Caution Note that setting the configuration parameters in the php.ini file will affect all the other php applications on the same server. A missconfiguration in one of these values will torpedo your whole site not to mention phpWebSite.

Warning As noted with the other two ways of making these changes you should only pick one of these and use it alone.

_________________
The nose of a mob is its imagination. By this, at any time, it can be quietly led.
marine beneficial association


Top
 Profile E-mail  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 14 posts ] 


All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group