Joomla! Discussion Forums



It is currently Mon Nov 23, 2009 4:45 pm (All times are UTC )

 





Post new topic Reply to topic  [ 11 posts ] 
Author Message
Posted: Tue Jul 15, 2008 12:35 pm 
Joomla! Enthusiast
Joomla! Enthusiast
Offline

Joined: Mon Aug 20, 2007 6:46 pm
Posts: 181
edit: Original Subject: banned words in contact form parameters blocking all words

Hi all,

To avoid the spam to my Joomla! sites through the contact forms I have added "http" and "www" to the banned words... in the contact message field parameters.

Spam stopped immediately...But... So did all other mail from the contact form.. On checking this I am getting the message "your email contained banned words" every single time even if the banned word is not in the list set in the parameters...

If I remove all the words from the banned word settings and save I can then go to the front end and use the contact form without error... If there is a word in the banned word area of the contacts parameters then no emails at all are sent... It doesn't seem to matter if the banned word is written in the contact form or not, all attempts to send an email are rejected....

Could anyone else confirm this? Right now I have removed my banned word list and am open to spam again...

Database Version: 5.0.51a-community
Database Collation: utf8_general_ci
PHP Version: 5.2.5
Web Server: Apache/2.2.8 (Unix) mod_ssl/2.2.8 OpenSSL/0.9.7a DAV/2 mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635
Web Server to PHP interface: cgi-fcgi
Joomla! Version: Joomla! 1.5.4 Production/Stable [ Naiki ] 6-July-2008 22:00 GMT
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.9) Gecko/2008052906 Firefox/3.0


Clive


Top
   
 
Posted: Tue Jul 15, 2008 12:45 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15089
Hi Clive,

Confirmed, after doing a quick test. I'll add it to the bug tracker.

Tracker: http://joomlacode.org/gf/project/joomla ... m_id=11839

_________________
Regards Robin


Top
   
 
Posted: Tue Jul 15, 2008 12:59 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Thu Aug 18, 2005 8:43 pm
Posts: 5759
Location: New York
what happens if you don't put html in the banned list but just use regular words?

_________________
Read your words before posting and think about how other people will read them.
Be polite. Be kind. Be constructive. Say thank you.
Freedom-Equality-Trust-Community-Collaboration-Usability
http://opensourcematters.org/index.php?Itemid=134


Top
   
 
Posted: Tue Jul 15, 2008 1:07 pm 
Joomla! Enthusiast
Joomla! Enthusiast
Offline

Joined: Mon Aug 20, 2007 6:46 pm
Posts: 181
Thank you for the confirmation and adding it to the bug tracker... I find the support in this forum excellent.... :)
It is hard sometimes for us non Joomla experts to know whether it is a user error or a bug...

I just tested by adding a random word to the banned word list in the banned text area... I used the word "great" and saved. In the front end trying to send a message that did not have this word in it resulted in an error message... "your email contains banned text"...

Clive


Top
   
 
Posted: Tue Jul 15, 2008 2:05 pm 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Thu Nov 10, 2005 3:10 am
Posts: 1919
Location: New Jersey, USA
A patch has been attached to the tracker which appears to fix this issue. Please test if possible...

_________________
Anthony Ferrara - Core Team - Development Coordinator - Bug Squad - JSST

http://moovum.com/ - The Bird is in the air! Get Mollom Anti-Spam on your Joomla! website with Moovur...
http://www.joomlaperformance.com For All Your Joomla Performance Needs


Top
   
 
Posted: Tue Jul 15, 2008 2:10 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15089
Clive,

In case you do not have a development environment to apply the patch, let us know so we can attach the altered file instead.

_________________
Regards Robin


Top
   
 
Posted: Tue Jul 15, 2008 2:25 pm 
Joomla! Enthusiast
Joomla! Enthusiast
Offline

Joined: Mon Aug 20, 2007 6:46 pm
Posts: 181
Hi,

I don't have a development environment... My sites are live

If you could attach the file and tell me where to put it I would be grateful.

Clive


Top
   
 
Posted: Tue Jul 15, 2008 7:05 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15089
Hi Clive,

File location: components/com_contact/controller.php

See attachment ;)


You do not have the required permissions to view the files attached to this post.

_________________
Regards Robin


Top
   
 
Posted: Tue Jul 15, 2008 8:51 pm 
Joomla! Enthusiast
Joomla! Enthusiast
Offline

Joined: Mon Aug 20, 2007 6:46 pm
Posts: 181
Hi all,
After uploading the new file I had an odd error whereby the email copy was received but though the success message showed the email was sent but it wasn't received to the email set for the contact us form... This happened a few times so I put the old file back and both emails got sent and received again... I re uploaded the new file and the problem had gone away... I don't know what caused this...

Any way, I then tested and these are the results

Testing with the old file and a banned word entered in the banned text area
Result, all messages are blocked.

Testing with the old file and no word entered into the banned text area.
Result, both the email enquiry and the copy sent and received

Testing the new file with no banned words entered in the banned text area.
Result, both the email enquiry and the copy sent and received

Testing the new file with a word entered in the banned text area but not putting the banned word into the email body.
Result, both the email enquiry and the copy sent and received

Testing the new file with a word entered in the banned text area and adding the banned word to the email body.
Result, mail not sent and error message displayed.. When the page refreshes to give the banned word notice the contact form has disappeared so to get it again you either have to click the back button or the contact us link to get the form again.

I think the error is fixed.... :)

Thank you everyone

Clive


Top
   
 
Posted: Wed Jul 16, 2008 4:44 am 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 12:38 am
Posts: 11193
Location: Sydney - Australia
Nice work all: http://community.joomla.org/core-team-b ... ation.html and especially Clive, our newest community contributor :)

_________________
Brad Baker - Follow me on Twitter @xyzulu @rochenhost
http://www.rochen.com - Joomla! Hosting, the correct way.
http://www.joomlatutorials.com <-- Joomla Help
..somewhere in this hospital the anguished oink of a pig man cries out for help..


Top
  E-mail  
 
Posted: Thu Jul 17, 2008 3:23 pm 
User avatar
Joomla! Guru
Joomla! Guru
Offline

Joined: Mon Mar 20, 2006 8:17 am
Posts: 736
DEV Notes; Marked "FIXED" and move to resolved forum.
Fixed in SVN

_________________
bento2go.com - We DO NOT sell bento !!


Top
  E-mail  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 11 posts ] 

Quick reply

 



Who is online

Users browsing this forum: No registered users and 26 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group