The Joomla! Forum ™

Download

Demo


Board index » Joomla! Development Forums » Joomla! Development » Joomla! 1.5 Bug Reporting

Forum rules


Forum Rules
Forum Post Assistant - If you are serious about wanting help, you will use this tool to help you post.



Post new topic Reply to topic  Page 2 of 5
  [ 139 posts ]  Go to page Previous  1, 2, 3, 4, 5  Next
  Print view Previous topic | Next topic 
Author Message
Soul Reaver
PostPosted: Mon Mar 02, 2009 10:44 pm 
User avatar
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 24, 2008 10:27 pm
Posts: 18
Location: Oz
Any updates on this as yet???

I thought i was losing my mind when upgraded to 1.5.9 and the login module redirects to home, but after reading this i can see it's an issue.

I agree with the majority here, when a user logs in via the login module they should be put back on the same page not home.

_________________
I'm new be gentle :O
Top
 Profile  
 
dextercowley
PostPosted: Thu Mar 05, 2009 10:51 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso

Joined: Sun Apr 06, 2008 4:44 am
Posts: 3289
Location: Seattle, WA, USA
Hi. We have a patch for this issue. We now need people to test it. Here is the link: http://joomlacode.org/gf/project/joomla ... m_id=15376. If we can get it successfully tested by two people, it can go into the next Joomla! release. Thanks! Mark

_________________
Mark Dexter
"Well...how did I get here?"
Top
 Profile  
 
infograf768
PostPosted: Fri Mar 06, 2009 8:03 am 
User avatar
Joomla! Master
Joomla! Master

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 16668
Location: **Translation Matters**
Having some issues, Mark. Posting on joomlacode.

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 2.5: http://help.joomla.org/files/EN-GB_multilang_tutorial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group
Top
 Profile  
 
dlebreux
PostPosted: Fri Mar 06, 2009 8:01 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Thu Jul 24, 2008 2:20 am
Posts: 29
Sorry, still a newbie....how did I install & test the .patch file?

I'd love to help move this along.

I also have DOCman installed and I'd like to make sure that it works with that as well too.

thanks to all for pushing forward with this. Really appreciated.
Top
 Profile  
 
dextercowley
PostPosted: Fri Mar 06, 2009 8:35 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso

Joined: Sun Apr 06, 2008 4:44 am
Posts: 3289
Location: Seattle, WA, USA
Hi. Well, to install a patch you need to have a copy of Joomla! under Subversion source control. One way to do that is to use Eclipse with Subversion. It's a fair bit of setup, but worth it if you want to use an IDE for PHP/Joomla! development. Here is a link with detailed instructions: http://docs.joomla.org/Setting_up_your_ ... evelopment.

If you don't want to go through all of that, in this case it's pretty easy to manually make the change. The patch file looks like this:
Code:
Index: modules/mod_login/helper.php
===================================================================
--- modules/mod_login/helper.php   (revision 11645)
+++ modules/mod_login/helper.php   (working copy)
@@ -26,7 +26,9 @@
       }
       else
       {
-         $url = JURI::base(true);
+         // stay on the same page
+         $uri = JFactory::getURI();
+         $url = $uri->toString(array('path', 'query', 'fragment'));
       }
 
       return base64_encode($url);
So this is telling you to go down to line 26 in the file modules/mod_login/helper.php and find the lines shown below that. Delete the line "$url = JURI::base(true);" and add in it's place the three lines with "+".

Hope this helps. Mark

_________________
Mark Dexter
"Well...how did I get here?"
Top
 Profile  
 
metaltome
PostPosted: Mon Mar 16, 2009 7:21 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Fri Jan 23, 2009 7:47 pm
Posts: 16
I have applied the hack above to the latest version of Yoologin 1.5.9 and am hosting the fixed file on my server. It will keep users on whatever page they choose to login at. Just keep the redirection settings on:

- Select Item -

Simply Install via Joomla Backend! Enjoy!

http://www.metaltome.com/downloads/mod_yoo_login_1.5.9Fixed.zip
Top
 Profile  
 
dlebreux
PostPosted: Mon Mar 16, 2009 7:59 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Thu Jul 24, 2008 2:20 am
Posts: 29
I applied the patch (manually) as well and it seems to be working fine.
I'm on J! 1.5.9 with a LAMP set up.
This is on an internal company website so I can't share the link but I'll let you know if anything odd happens.
But so far so good.

Thanks A MILLION for doing this. :D

My users will be VERY happy.
Top
 Profile  
 
Soul Reaver
PostPosted: Tue Mar 17, 2009 10:39 pm 
User avatar
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 24, 2008 10:27 pm
Posts: 18
Location: Oz
Above patch applied, working as expected. Thank you to all involved in this, hoping this is corrected in the next release.

_________________
I'm new be gentle :O
Top
 Profile  
 
dextercowley
PostPosted: Tue Mar 17, 2009 11:23 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso

Joined: Sun Apr 06, 2008 4:44 am
Posts: 3289
Location: Seattle, WA, USA
Hi. Yes, this issue is corrected in the SVN, which means that it will be included in version 1.5.10. Mark

_________________
Mark Dexter
"Well...how did I get here?"
Top
 Profile  
 
razzle
PostPosted: Thu Mar 19, 2009 11:38 pm 
Joomla! Fledgling
Joomla! Fledgling

Joined: Tue Nov 06, 2007 3:48 am
Posts: 3
metaltome wrote:
I have applied the hack above to the latest version of Yoologin 1.5.9 and am hosting the fixed file on my server. It will keep users on whatever page they choose to login at. Just keep the redirection settings on:

- Select Item -

Simply Install via Joomla Backend! Enjoy!

http://www.metaltome.com/downloads/mod_yoo_login_1.5.9Fixed.zip


Metaltome... YOO are da'MANNNN! Thanx from a grateful user! ;D You're the guy that makes Joomla! the best CMS on the planet!!!
Top
 Profile  
 
saintwright
PostPosted: Thu Mar 26, 2009 3:35 am 
Joomla! Fledgling
Joomla! Fledgling

Joined: Thu Mar 26, 2009 3:32 am
Posts: 3
Hi - I have tried changing the code as requested but I still get returned to the index page - and I have not selected any pages in the login module. Any ideas??
Top
 Profile  
 
dlebreux
PostPosted: Thu Mar 26, 2009 4:34 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Thu Jul 24, 2008 2:20 am
Posts: 29
My only thought (simple as it may be) is that you didn't edit the code properly.
When I first did this (not having any experience with PHP) I added the code as displayed.
After re-reading and testing I found out that you need to delete that first line and then show the next 3 wthout the + sign.
Sounds stupid but that's what got me for a minute. :-[
Top
 Profile  
 
saintwright
PostPosted: Thu Mar 26, 2009 7:27 am 
Joomla! Fledgling
Joomla! Fledgling

Joined: Thu Mar 26, 2009 3:32 am
Posts: 3
I did remove the + and -: see code below.

function getReturnURL($params, $type)
{
if($itemid = $params->get($type))
{
$menu =& JSite::getMenu();
$item = $menu->getItem($itemid);
$url = JRoute::_($item->link.'&Itemid='.$itemid, false);
}
else
{
// stay on the same page
$uri = JFactory::getURI();
$url = $uri->toString(array('path', 'query', 'fragment'));

}

return base64_encode($url);
}
Top
 Profile  
 
dlebreux
PostPosted: Thu Mar 26, 2009 1:02 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Thu Jul 24, 2008 2:20 am
Posts: 29
And you're sure the Login Module doesn't show a redirect page anymore, correct?

The fix for this is going to be in 1.5.10 and that's expected to be released some time this week.

I didn't have time now to review what you added but I might later today. If anyone else can help out please jump in.
Top
 Profile  
 
saintwright
PostPosted: Thu Mar 26, 2009 10:53 pm 
Joomla! Fledgling
Joomla! Fledgling

Joined: Thu Mar 26, 2009 3:32 am
Posts: 3
Ok - thanks for your help - but I have been a bit dumb - or I can blame my newbie status with Joomla - I needed to add the return url into a querystring that calls the login page as I am not using the login module but the login page. So I have got it working - by chaning teh url to:

/joomlamums/index.php?option=com_user&view=login&Itemid=69&return=<?php echo $returnurl; ?>

Thanks again for answering my questions!

S :-[
Top
 Profile  
 
mlipscomb
PostPosted: Sat Mar 28, 2009 5:40 am 
User avatar
Joomla! Ace
Joomla! Ace

Joined: Thu Mar 26, 2009 5:38 pm
Posts: 1272
Location: Gadsden, AL
Thanks a lot of the mod.

If anyone needs to see it in action it is up and going at http://www.foodcreate.com

A quick side note - if you have this published and have already messed with a redirect, make sure you set it back to none - otherwise it will continue to redirect custom. I know most of y'all will automatically know that - but there are those that it can frustrate after way too many tries! :-)

_________________
~Matt Lipscomb
http://www.USAFreelancers.org
Professional Joomla! Services and Web Development based in the USA
Top
 Profile  
 
dlebreux
PostPosted: Mon Mar 30, 2009 1:30 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Thu Jul 24, 2008 2:20 am
Posts: 29
FYI - now that 1.5.10 is out there's no need for self patching the file. Just update Joomla! to the latest version and the login should work fine.
Top
 Profile  
 
xt4london
PostPosted: Mon Apr 20, 2009 12:19 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Nov 19, 2007 9:00 pm
Posts: 30
Location: London
I've used this hack for the login MODULE and it works!. What about the COMPONENT? Will it work for that too?
Top
 Profile  
 
mlipscomb
PostPosted: Mon Apr 20, 2009 2:28 pm 
User avatar
Joomla! Ace
Joomla! Ace

Joined: Thu Mar 26, 2009 5:38 pm
Posts: 1272
Location: Gadsden, AL
What component?

_________________
~Matt Lipscomb
http://www.USAFreelancers.org
Professional Joomla! Services and Web Development based in the USA
Top
 Profile  
 
xt4london
PostPosted: Tue Apr 21, 2009 12:24 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Nov 19, 2007 9:00 pm
Posts: 30
Location: London
By component I mean when say you have a restricted page and a user attempts to go to that page and a log in screen is called. This is not the same as the login module (although it looks the same). Or it's when you create a menu log in. This creates a component log in as opposed to a module log in. The hack above works for the module but not the component.
Top
 Profile  
 
mlipscomb
PostPosted: Tue Apr 21, 2009 12:49 am 
User avatar
Joomla! Ace
Joomla! Ace

Joined: Thu Mar 26, 2009 5:38 pm
Posts: 1272
Location: Gadsden, AL
if you upgrade to 1.5.10 it handles this.

_________________
~Matt Lipscomb
http://www.USAFreelancers.org
Professional Joomla! Services and Web Development based in the USA
Top
 Profile  
 
zoink
PostPosted: Wed Apr 22, 2009 8:23 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 09, 2009 7:28 pm
Posts: 5
No, 1.5.10 does not correct the problem for the login component, only the module. If you create a login menu item (User -> Login menu item type) or call up the com_user component's login view directly with an external link menu item, then attempt to login, you will not be redirected to the same page you came from (referrer page).
Top
 Profile  
 
mlipscomb
PostPosted: Wed Apr 22, 2009 3:33 pm 
User avatar
Joomla! Ace
Joomla! Ace

Joined: Thu Mar 26, 2009 5:38 pm
Posts: 1272
Location: Gadsden, AL
Oh - I see what you're talking about. Instead it just stays on the login page or redirects to account details, right?

_________________
~Matt Lipscomb
http://www.USAFreelancers.org
Professional Joomla! Services and Web Development based in the USA
Top
 Profile  
 
zoink
PostPosted: Thu Apr 23, 2009 4:44 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 09, 2009 7:28 pm
Posts: 5
That's correct. It simply takes you to a redirect page that you can choose from your available menu items (if you arrive at the login view through a menu by clicking on a User->Login menu item type where you've configured the redirect settings) or to the index page (if you don't configure the redirect settings or you arrive at the login view through a menu item of type "External" which links to the index?option=com_user&view=login directly). This is very limiting because redirect to the page the user came from is a feature needed by a lot of people, and the login view of the component should have the same behavior as the module so there is flexibility in designing a site without a whole bunch of weird quirks...
Top
 Profile  
 
xt4london
PostPosted: Thu Apr 23, 2009 1:09 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Nov 19, 2007 9:00 pm
Posts: 30
Location: London
Agree with Zoink on this but what is really needed is the ability to go to the restricted page (the page that you need to be logged in to see) once the log in has happened.
Top
 Profile  
 
mlipscomb
PostPosted: Thu Apr 23, 2009 3:23 pm 
User avatar
Joomla! Ace
Joomla! Ace

Joined: Thu Mar 26, 2009 5:38 pm
Posts: 1272
Location: Gadsden, AL
I really think that having that be an "option" compared to automatic would be the best route since sometimes it's needed to go directly to the account page (especially if other advanced options for profile editing are used.)

Would anyone be interested in using a different component for the menu login link? That way for our needs you still have the option of directing users through the regular com_login or using the different component for previous page redirect.

_________________
~Matt Lipscomb
http://www.USAFreelancers.org
Professional Joomla! Services and Web Development based in the USA
Top
 Profile  
 
zoink
PostPosted: Fri Apr 24, 2009 1:25 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 09, 2009 7:28 pm
Posts: 5
As long as it functioned the same as and possibly even just utilized the normal com_user component's login view, I would be interested. The only thing that's really needed is to find the redirect URL (current page), base64 encode it, and stick it onto the end of the query string of the link generated by the menu item.

Example:

index.php?option=com_user&view=login&return=qopa93jAkzjrhkjAEU

where return is the base64-encoded return URL

This could probably be done with a new component implementing this functionality and accessed through a new menu item type.

Also, it would be helpful to have the same for a logout menu item.

However, I'm not sure if it's possible to dynamically generate the link URL for a menu item on page load...
Top
 Profile  
 
mcsmom
PostPosted: Tue Apr 28, 2009 10:28 am 
User avatar
Joomla! Exemplar
Joomla! Exemplar

Joined: Thu Aug 18, 2005 8:43 pm
Posts: 7846
Location: New York
If you click on a login link, the referrer page IS the login page. What you want is to go to the page before the referrer page. There has never been that feature, although it sure would be cool.

_________________
So we must fix our vision not merely on the negative expulsion of war, but upon the positive affirmation of peace. MLK 1964.
http://officialjoomlabook.com Get it at http://www.joomla.org/joomla-press-official-books.html Buy a book, support Joomla!.
Top
 Profile  
 
zoink
PostPosted: Sun May 10, 2009 12:51 am 
Joomla! Apprentice
Joomla! Apprentice

Joined: Mon Mar 09, 2009 7:28 pm
Posts: 5
Not the referrer to the post action, I was referring to the referrer of the login page request. Do you get my reference?

I refer you to my previous posts.
Top
 Profile  
 
David0204
PostPosted: Tue May 12, 2009 11:07 pm 
Joomla! Apprentice
Joomla! Apprentice

Joined: Sun Mar 22, 2009 12:11 am
Posts: 12
Hello all. Any new development on this issue? I just upgraded my site to 1.5.10 and still have the same problem: after you login in the Kunena discussion forum you are redirected to Home instead of the actual discussion forum.

Any new hack on this?

thanks

David
Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  Page 2 of 5
  [ 139 posts ]  Go to page Previous  1, 2, 3, 4, 5  Next


Board index » Joomla! Development Forums » Joomla! Development » Joomla! 1.5 Bug Reporting

Who is online

Users browsing this forum: No registered users and 7 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group