[FIXED][CONFIRMED:9198]Change menu type - svn9194

robiw · **Joined:** Fri Jun 16, 2006 3:24 pm **Posts:** 71

Changing menu item in 9194 not working.

Editing mainmenu item allows change to be made but not saving new choice.

---robiw

mihu · **Joined:** Mon Mar 20, 2006 8:17 am **Posts:** 736

TEST W/ SVN 9198
CONFIRMED

User allow to change menu type; however, nothing will be change after "save".

kelb · **Posted:** Tue Oct 09, 2007 12:08 am

9199

After changing type of menu and saving it, a new menu appears and the old one is still there.

robiw · **Joined:** Fri Jun 16, 2006 3:24 pm **Posts:** 71

Same as above on 9194. Original post was made before it was noticed that the original menu item is not changed but a new menu item is created and inserted at the foot of the menu leaving both menu items published.

ianmac · **Posted:** Tue Oct 16, 2007 9:04 pm

Can you confirm what I'm seeing? If I try to change the menu type, I can select a new type, but then instead of going back to Edit Menu Item screen, it goes to New Menu Item. It seems like the id is not being carried through.

Ian

kelb · **Posted:** Tue Oct 16, 2007 9:16 pm

Confirmed.

kelb · **Posted:** Tue Oct 16, 2007 9:18 pm

But, isn't this normal?

ianmac · **Posted:** Tue Oct 16, 2007 11:33 pm

My expectation was that if I click on 'Change Menu Type', that it will go to the Select Menu Item Type screen. Once I select a menu type, it should return to the edit menu item screen, with all the previous menu item information (i.e. Title, Alias, some parameters, etc...).

Ian

kelb · **Posted:** Tue Oct 16, 2007 11:39 pm

So this is an normal case.

However first bug still exists.

ianmac · **Posted:** Wed Oct 17, 2007 12:52 am

Well, contrary to my expectation, when I select a type from the menu type selection screen (after clicking change menu type), it then goes back to the New Menu Item screen, and all the information is gone (i.e. the Title and Alias, etc are blank). So it is logical to conclude that if one were to save after that, then it would create a new menu item instead of changing the old one... hence the first problem...

Ian

ianmac · **Posted:** Wed Oct 17, 2007 12:54 am

To elaborate, it doesn't look like com_menus is designed to allow changed the menu type... if you look at the controller's type() function, we see:

Code:

        function type()
        {
                JRequest::setVar( 'edit', false );
                $model  =& $this->getModel( 'Item' );
                $view =& $this->getView( 'Item' );
                $view->setModel( $model, true );

                // Set the layout and display
                $view->setLayout('type');
                $view->type();
        }

note that it sets 'edit' to false.

Ian

Robin · **Joined:** Thu Aug 18, 2005 10:41 am **Posts:** 15089

Dev note; http://joomlacode.org/gf/project/joomla ... em_id=7606

mihu · **Joined:** Mon Mar 20, 2006 8:17 am **Posts:** 736

Test w/ SVN 9362
The issue is FIXED.

Joomla! Discussion Forums

Forum rules: Please click here to view the forum rules

[FIXED][CONFIRMED:9198]Change menu type - svn9194

Quick reply

Who is online