Joomla! Discussion Forums



It is currently Thu Nov 26, 2009 9:58 pm (All times are UTC )

 





Post new topic Reply to topic  [ 6 posts ] 
Author Message
Posted: Sun Oct 29, 2006 6:47 pm 
User avatar
Joomla! Explorer
Joomla! Explorer
Offline

Joined: Sun Jun 11, 2006 10:29 am
Posts: 291
Location: Netherlands
For php to execute the php code, all the code should be

Here is the right code:
Code:
<?php
/**
* @copyright Copyright (C) 2005 - 2006 Open Source Matters. All rights reserved.
* @license GNU/GPL, see LICENSE.php
* Joomla! is free software. This version may have been modified pursuant
* to the GNU General Public License, and as distributed it includes or
* is derivative of works licensed under the GNU General Public License or
* other free or open source software licenses.
* See COPYRIGHT.php for copyright notices and details.
*/
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $this->language; ?>" lang="<?php echo $this->language; ?>" dir="<?php echo $this->direction; ?>">
<head>
   <jdoc:include type="head" />
   <link rel="stylesheet" href="templates/_system/css/general.css" type="text/css" />
   <link rel="stylesheet" href="templates/<?php $mainframe->getTemplate(); ?>/css/general.css" type="text/css" />
</head>
<body class="contentpane">
   <jdoc:include type="component" />
</body>
</html>


Very big bug! So put this as fast as possible into the svn. Should be fixed soon.

Edit 1:
Here is the actual code (the old code)
Code:
<?
/**
* @copyright Copyright (C) 2005 - 2006 Open Source Matters. All rights reserved.
* @license GNU/GPL, see LICENSE.php
* Joomla! is free software. This version may have been modified pursuant
* to the GNU General Public License, and as distributed it includes or
* is derivative of works licensed under the GNU General Public License or
* other free or open source software licenses.
* See COPYRIGHT.php for copyright notices and details.
*/
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?= $this->language; ?>" lang="<?= $this->language; ?>" dir="<?= $this->direction; ?>">
<head>
   <jdoc:include type="head" />
   <link rel="stylesheet" href="templates/_system/css/general.css" type="text/css" />
   <link rel="stylesheet" href="templates/<?= $mainframe->getTemplate(); ?>/css/general.css" type="text/css" />
</head>
<body class="contentpane">
   <jdoc:include type="component" />
</body>
</html>

As you can see this code uses

Edit 2:
The install template uses also the
_________________
Founder and Lead developer of JAM (http://joomladev.org)
JAM is the first J!1.5 only component using AJAX!


Last edited by Jinx on Mon Oct 30, 2006 10:34 pm, edited 1 time in total.

Top
  E-mail  
 
Posted: Sun Oct 29, 2006 7:24 pm 
User avatar
Joomla! Guru
Joomla! Guru
Offline

Joined: Sat Aug 20, 2005 12:32 pm
Posts: 990
Location: Tewkesbury, UK
I fail to see any big - all the PHP code is withing PHP Tags.

_________________
Phil Taylor - Full Time Expert Joomla-Only Developer
Blue Flame IT Ltd.
-- http://www.phil-taylor.com/
SPEED UP Joomla 1.5.x Admin Console with this: http://extensions.joomla.org/extensions ... 53/details


Top
   
 
Posted: Sun Oct 29, 2006 8:13 pm 
User avatar
Joomla! Hero
Joomla! Hero
Offline

Joined: Thu Aug 25, 2005 5:48 pm
Posts: 2801
Location: Geneva mostly
problem is that in SVN, it's only
_________________
Sometimes one pays most for the things one gets for nothing.
The important thing is not to stop questioning. Curiosity has its own reason for existing. AE
http://joomla15.blogspot.com for J! 1.5 screenshots
http://www.eyezberg.com


Top
  E-mail  
 
Posted: Mon Oct 30, 2006 1:45 pm 
User avatar
Joomla! Guru
Joomla! Guru
Offline

Joined: Sat Aug 20, 2005 12:32 pm
Posts: 990
Location: Tewkesbury, UK
Ahhh

I would neither call that a PHP5 issue or a Bug :-) :-)

PHP5 can, with the correct php.ini configuration, handle short open tags as can PHP4

I guess it should be changed though, I would just not say its a major issue.

_________________
Phil Taylor - Full Time Expert Joomla-Only Developer
Blue Flame IT Ltd.
-- http://www.phil-taylor.com/
SPEED UP Joomla 1.5.x Admin Console with this: http://extensions.joomla.org/extensions ... 53/details


Top
   
 
Posted: Mon Oct 30, 2006 4:09 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 16, 2005 8:41 pm
Posts: 3652
Location: NRW - Germany
with my incredible telepathic abilities to find the files, I fixed it in SVN

_________________
god doesn't play dice with the universe. not after that drunken night with the devil where he lost classical mechanics in a game of craps.

Since the creation of the Internet, the Earth's rotation has been fueled, primarily, by the collective spinning of English teachers in their graves.


Top
   
 
Posted: Mon Oct 30, 2006 5:00 pm 
User avatar
Joomla! Explorer
Joomla! Explorer
Offline

Joined: Sun Jun 11, 2006 10:29 am
Posts: 291
Location: Netherlands
Hackwar wrote:
with my incredible telepathic abilities to find the files, I fixed it in SVN


WoW. This is a moment to never forget. I saw a devrloper making a joke ;D
Anyway. Ok thx :)

_________________
Founder and Lead developer of JAM (http://joomladev.org)
JAM is the first J!1.5 only component using AJAX!


Top
  E-mail  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

Quick reply

 



Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group