Joomla! Discussion Forums

Description:
I found a bug in version 1.0.9 about the alt tags of images from the template. It has been resolved for the new version. But I found there another problem which hasn't been corrected. I turned on the voting for every content item on my page, and when I'm looking on a blog category page, and I got dozens of warnings because all voting stars have the same name="image" property, and the XHTML specs say, that the name attribute should be unique.

Reported on:
Joomla 1.0.10, freshly upgraded from 1.0.9

Classification:


Affected functions:


Related files:


Steps to replicate:
Turn on the voting option in the global configuration, and don't override it by the articles. I don't know, wether it matters if the stars are taken from the template or the built-in one, at my site it was taken from the template. Now all the stars are named image.

Analysis:


Proposed fix(es):
If no name is given as a parameter in the CheckImage function, don't output name="Image" but nothing in the output img tag.


Topic / Artifact ID:


System info:
I'm using Joomla 1.0.10 upgraded from 1.0.9., core SEF turned on, OpenSEF installed, but turned off (some other problems kicked in, but it has nothing to do with Joomla).

Hi Stampie, thanks for the report.

At first I thought that this was just down to how strict you go with compliance (my site validates with the w3c validator - no warnings) but when I looked at the imagecheck function again
/includes/joomla.php


It does look like a bug as this

seems to me to be trying to output the name attribute if one exists, otherwise do not output one.

which conflicts with the fact that a default value is assigned to $name in the function


I edited the function to have argument $name=NULL instead of $name='image' and this seems to do the trick

I have added this to the tracker
http://forge.joomla.org/sf/go/artf5141?nav=1

Resolved: http://forge.joomla.org/sf/go/artf5141?nav=1.  Moving to resolved forum.