Description:
For component developers mosCommonHTML::menuLinksContent() contains specific javascript which needs generalisation
Reported on:
Joomla 1.0.11
Classification:
Enhancement
Affected functions:
Any 3rd party component that wants to call this function and which doesnt have an image list on their admin page
Related files:
includes/joomla.php
Steps to replicate:
Download mosforms 0.4b install add a table, link table to menu, click on the 'menu' or 'link name' links - gives js error "form.imagelist.options not defined"
Analysis:
Proposed fix(es):
In mosCommonHTML::menuLinksContent() replace
Code:
<script language="javascript" type="text/javascript">
function go2( pressbutton, menu, id ) {
var form = document.adminForm;
// assemble the images back into one field
var temp = new Array;
for (var i=0, n=form.imagelist.options.length; i < n; i++) {
temp[i] = form.imagelist.options[i].value;
}
form.images.value = temp.join( '\n' );
if (pressbutton == 'go2menu') {
form.menu.value = menu;
submitform( pressbutton );
return;
}
if (pressbutton == 'go2menuitem') {
form.menu.value = menu;
form.menuid.value = id;
submitform( pressbutton );
return;
}
}
</script>
with
Code:
<script language="javascript" type="text/javascript">
function go2( pressbutton, menu, id ) {
var form = document.adminForm;
// assemble the images back into one field
var temp = new Array;
if(form.imagelist){
for (var i=0, n=form.imagelist.options.length; i < n; i++) {
temp[i] = form.imagelist.options[i].value;
}
form.images.value = temp.join( '\n' );
}
if (pressbutton == 'go2menu') {
form.menu.value = menu;
submitform( pressbutton );
return;
}
if (pressbutton == 'go2menuitem') {
form.menu.value = menu;
form.menuid.value = id;
submitform( pressbutton );
return;
}
}
</script>
System info:
n/a
Login
Register
Rules
FAQ
The team
