Tell a Friend, Send page, Recommend to a Friend. Site + current page

maddunr · **Joined:** Thu Oct 06, 2005 4:43 pm **Posts:** 304

hey elmoch,

btw, can u also consider adding a module suffix for the module? it will be very helpful in customizing the appearance

- v

elmoch · **Posted:** Mon Jul 10, 2006 11:53 am

In fact I did last time, but I removed it because I frankly didn't understand much how it works and I was centered on my problem with IE. :-[

However, it mustn't be that difficult, I suppose. I will add that feature to the wishlist $:-\$

Thanks for reminding me of it.

elmoch · **Posted:** Tue Aug 22, 2006 11:54 am

Hi,

I have released JM-Recommend v1.1 RC1.

I have solved the troubles with IE not opening the form in the pop-up window and not parsing the URL's. But another problem has arisen as I cannot get the module to present SEF URL's.

It now parses and renders the URL's OK except that they are not converted to SEF ones.
I have left some commented lines in the code just in case someone can help.

Thanks in advance.

Find the .zip files attached to the first post in this thread.

maddunr · **Joined:** Thu Oct 06, 2005 4:43 pm **Posts:** 304

Ok. I don't know what happened.. but my JM_Recommend component and modules are both broken!

The beta version was working fine until I upgraded to the latest version (RC 1.1) yesterday, and noticed that the component / modules are not working - the popup form comes up fine but all information regarding the website (name, url etc.) are missing. I tried going back to the beta version, but even that is not working any more!

Please take a look at this site and let me know if you can help.

- V

elmoch · **Posted:** Thu Aug 24, 2006 6:46 pm

Hi maddunr, thank you for trying the package again.

I guess you simply overwrote the old files, which broke it all because of the different way the new version works.
I forgot to tell how to upgrade: the right way is "uninstall old stuff, then install new stuff".
If you can't do that from the Admin Panel now, do this:

Delete the folder yoursite/administrator/components/com_jm-recommend/
Delete the folder yoursite/components/com_jm-recommend/
Delete the folder yoursite/modules/mod_jm-recommend/
In yoursite/modules/ delete the files mod_jm-recommed.php and mod_jm-recommed.xml

Only if necessary... BEFORE INSTALLING the new package

In your database (using phpMyAdmin, for example)

delete the table jos_jmrecommend_config
in table jos_components delete the row(s) corresponding to JM-Recommend
in table jos_modules delete the row(s) corresponding to JM-Recommend

Then install version 1.1 RC1. Everything must work OK.

BTW, I implemented sort of a class suffix. Please, let me know if it works. :-[

Thanks for feedback!

maddunr · **Joined:** Thu Oct 06, 2005 4:43 pm **Posts:** 304

Hey elmoch,

Glad to be of help

But it still doesn't work for me. I uninstalled the old module and checked all the folders, files and db tables but the uninstall seemed clean - there was no record anywhere. Then I installed the latest version and tried it again - doesn't work.

- V

elmoch · **Posted:** Thu Aug 24, 2006 10:36 pm

That's quite strange. ???

First of all, you have to install both the new component and the new module. Otherwise the latter won't work.

I have downloaded the files attached to the first post here to make sure that they were correct.

Uninstalled the module first, then uninstalled the component.

Re-installed the component first, then re-installed the module.
I tested both and everything was OK!

I checked the .xml files too and they seem to be correct, so... :-\

My system:

MySQL: 4.0.27-standard
PHP Version: 4.4.2
Web Server: Apache/1.3.36 (Unix)
Joomla! Version: Joomla! 1.0.10 Stable [ Sundown ] 26 June 2006 00:00 UTC
Safe Mode: OFF

I have looked at your source code and apparently the link is formated correctly so it seems to me that the problem comes from the file yoursite/components/com_jm-recommend/jm-recommend.html.php where the URL is decoded.
Have you installed the new component? >:(

SkyDK · **Posted:** Sun Sep 10, 2006 6:51 pm

Hi.

Im working on a site (a virtual mart shop) how do i add a link on each product site?

elmoch · **Posted:** Sun Sep 10, 2006 10:06 pm

Hi SkyDK,

I'm sorry but my package is not integrated with any other component. The standard way to allow your visitors to recommend the current page is installing and publishing the module, there's no link to be added.
I suppose this may not work inside another application. Anyway this is open source software and it can be freely integrated with other components by anyone willing to do so.

Thanks for your interest.

SkyDK · **Posted:** Mon Sep 11, 2006 4:43 am

Hi Elmoch.

Ok, i was just wondering if there was a specific code i could implant that would do the trick.

elmoch · **Posted:** Mon Sep 11, 2006 11:29 am

Well, in fact this was asked in the virtueMart forum some time ago (see here), but I don't know if it was finally implemented.
The way JM-Recommend works now is: you publish the module, which, when clicked, calls the component and passes the current URL as a variable to be included in the email the user will send.

I hope this helps.

maddunr · **Joined:** Thu Oct 06, 2005 4:43 pm **Posts:** 304

skydk,

you can *try* adding a module position in your template that appears only when the itemid matches that of virtuemart. then set the module to show on all pages in the module settings. here's a sample code i used for category_id. you can change it for item_id too.

Code:

<?php  if ( mosGetParam ( $_REQUEST, 'category_id', null) == 1) { ?> <div><?php mosLoadModules('user9', -2); ?></div> <?php  } ?>

- V

hlarsen · **Joined:** Fri Sep 15, 2006 6:46 pm **Posts:** 34

First: Excellent - Was just what I was looking for - Thanks for making it and thanks for making it available to all of us -
Second: Feature suggestion: Optional 'Send copy of mail to self' -

Cheers

elmoch · **Posted:** Sat Oct 07, 2006 9:13 pm

hlarsen wrote:

First: Excellent - Was just what I was looking for - Thanks for making it and thanks for making it available to all of us -
Second: Feature suggestion: Optional 'Send copy of mail to self' -

Cheers

Thank you, hlarsen. I'm glad that you like it!
I'll try to implement the "second copy" feature when I have time.

Cheers

hlarsen · **Joined:** Fri Sep 15, 2006 6:46 pm **Posts:** 34

By the way, I solved the 'link'-problem mentioned above by adding these four lines to jm-recommend.php starting around line 51:

Code:

// Loads functions according to the parameters in the URL
global $task,$act,$url,$ttl;

///// Custom Start /////
$task = mosGetParam($_REQUEST, 'task');
$act = mosGetParam($_REQUEST, 'act');
$url = mosGetParam($_REQUEST, 'url');
$ttl = mosGetParam($_REQUEST, 'ttl');
///// Custom End /////

switch ( strtolower( $task ) ) {
   case 'send':
      recommendSend( $act,$url,$ttl );
      break;
   case 'form':
   default:
      recommendForm( $act,$url,$ttl );
      break;
}

Cheers

elmoch · **Posted:** Sun Oct 08, 2006 1:51 am

That's fantastic, hlarsen. Thanks a lot for your help! :laugh:

hlarsen · **Joined:** Fri Sep 15, 2006 6:46 pm **Posts:** 34

You're welcome - I am still happy you are making this add-on (and that I found it

)

In case it has any interest, I've taken the liberty of modifying your module to include the visitor overview from my stats - Using bbclone (please note, I've changed the default installation location of the bbclone component), i've added this towards the end of your code:

Code:

if ($jmr_format == '4')
{    
jmr_display_link($jmr_display_image,$jmr_site_def_image,$jmr_site_image,'1',NULL,$mosConfig_sitename,$jmr_site_text1,$jmr_form_width,$jmr_form_height);
}

////////// Custom Start //////////
 if (file_exists($mosConfig_absolute_path."/components/com_bbclone/var/access.php")) {

 require($mosConfig_absolute_path."/components/com_bbclone/var/access.php");
 $totalvisits   = $access["stat"]["totalvisits"];
 $totalcount    = $access["stat"]["totalcount"];
 $visitorsmonth = $access["time"]["month"][date("n")-1];
 $visitorstoday = $access["time"]["wday"][date("w")];
 $wday          = $access["time"]["wday"];

 for($week = 0; list(,$wdays) = each($wday); $week += $wdays);

echo "<table width=100% border=\"0\" cellpadding=\"1\" cellspacing=\"0\">\n"
     ."<tr><td colspan=\"2\"><hr width=\"100%\" size=\"2\"></td></tr>\n"

     ."<tr><td>Total Visits:   </td><td align=\"left\">\n"
     ."<div align=\"right\">$totalvisits</div></td></tr>\n"
     ."<tr><td>Total Unique:   </td><td align=\"left\">\n"
     ."<div align=\"right\">$totalcount</div></td></tr>\n"
     ."<tr><td>Visitors Month:   </td><td align=\"left\">\n"
     ."<div align=\"right\">$visitorsmonth</div></td></tr>\n"
     ."<tr><td>Visitors Week:   </td><td align=\"left\">\n"
     ."<div align=\"right\">$week</div></td></tr>\n"
     ."<tr><td>Visitors Today:   </td><td align=\"left\">\n"
     ."<div align=\"right\">$visitorstoday</div></td></tr>\n"
     ."</table>\n";
}
////////// Custom End //////////

// Indicates END of module
    echo "\n".'<!-- END Module : JM-Recommend '.$mversion.' by elmoch - www.poraqui.net -->'."\n\n";

Cheers and keep up the good work

elmoch · **Posted:** Sun Oct 08, 2006 2:29 pm

No problem at all.

This is the big thing about open source: we can improve others' work with almost no restrictions.
Thanks again for your good ideas!

laurie_lewis · **Joined:** Fri Oct 14, 2005 1:11 am **Posts:** 12

Hi - thanks for the work on the component and module. I have used an old version and updating my website to the latest versions of the software and have come across a few little issues.

Joomla 1.0.11
VirtueMart 1.0.7 (Used the ecommerce version to install)
All default settings for a new install

Issues:-

1. When I save the information in the component it is adding a / to some of the information in the recipients email and recipient fields
Friend's becomes Friend/'s if I save again Friend'/s becomes Friends//'s and so on.

2. I am getting " this page" and " the main page" showing in the module when it comes up.
Found that this is just a missing ";" on line 179 - currently reads

Code:

echo ' ';

should read

Code:

echo ' ';

Laurie

elmoch · **Posted:** Thu Oct 12, 2006 11:58 am

Thanks for the info, Laurie.
I have no time to revise the code right now, but if an older version worked OK I can send it to you. Just ask through a PM.

Cheers

laurie_lewis · **Joined:** Fri Oct 14, 2005 1:11 am **Posts:** 12

Hi elmoch,

No the current version is fine. I have just gone into the MYSQL DB and changed the settings to remove the backslashes. If you leave the default settings there are no problems.

Just for anyone else - if you want to add the module class suffix to the configuration you simply need to add the following line to the xml file that comes with the module.

Code:

<param name="moduleclass_sfx" type="text" default="" label="Module Class Suffix" description="A suffix to be aapplied to the css class of the module (table.moduletable), this allows individual module styling" />

This should be added between the & codes that are present.

Laurie

echang01 · **Joined:** Fri Sep 15, 2006 7:44 am **Posts:** 49

hi guys, i'm getting a

"missing ) after argument list"

error and my module's not working....... something to do with this line

any ideas? or is there a previous version that i can grab off someone?

elmoch · **Posted:** Tue Apr 10, 2007 4:18 pm

echang01 wrote:

any ideas? or is there a previous version that i can grab off someone?

I'm sorry but I don't have time to review the issue right now. Find attached the previous version, I hope that it will work for you.
And thanks for your interest.

UPDATE: Sorry. I had attached the last version again. 1.1 beta was last but one published.

hlarsen · **Joined:** Fri Sep 15, 2006 6:46 pm **Posts:** 34

Re the '-problem mentioned above: Another workaround would be: In admin.jm-recommend.php, line 107 to line 125 where-ever appropriate, I've added stripslashes, ie. changing

$_pagetitle = $database->getEscaped( $params->pagetitle );

to

$_pagetitle = stripslashes( $database->getEscaped( $params->pagetitle ));

@elmoch: When you get the time: If the sitename includes an ' (apostrophe), the message-form will not launch when you click the 'recommend'-links (both site and page) - I haven't found a place to fix it -

Cheers -

elmoch · **Posted:** Thu Apr 19, 2007 8:43 am

Good idea, hlarsen. And thanks for the feedback.
In mod_jm-recommend.php v1.1 RC1 the site name and URL are captured by lines # 109 to 112:

Code:

$requesturi = $_SERVER['REQUEST_URI'];
#$requesturi = sefRelToAbs(ampReplace($requesturi));
$thisurl = base64_encode($requesturi );
$thistitle = $mainframe->getPageTitle();

But v1.1 beta works in a different way, because it uses a JavaScript file. So in /modules/mod_jm-recommend/jm_recommend.js , lines # 26 to 28, it goes

Code:

function openForm(type,title,url,width,height) {

    window.open("index2.php?option=com_jm-recommend&task=form&act="+type+"&url="+escape(url)+"&ttl="+title+"","mywin","status=no,toolbar=no,scrollbars=yes,titlebar=no,menubar=no,resizable=yes,width="+width+",height="+height+",directories=no,location=no");
}

I tried both approaches but I didn't come to a definitive solution. On some systems they work, on others they don't, but I don't really know why.
I still don't have time to review the "package", so I hope these tips will help you if you want to keep on trying.
Thanks again. Cheers.

k0nan · **Joined:** Fri Apr 13, 2007 2:24 pm **Posts:** 49

works great after a bit of testing

it does his job, in version BETA, with joomla1.0.12 + virtuemart 1.0.12 + openSEF + joomla SEO enabled (with both options on the seo panel checked to yes).

with the same configuration but using the RC1 version, the one without JS, it does not work (no link or wrong link is printed into the recommend email body)

thank you, this is very useful, expecially with virtuemart as you may catch

elmoch · **Posted:** Fri Apr 27, 2007 11:32 am

Thanks for the feedback, k0nan.
I feel that I lack of knowledge to develop the package as I would like to, but at least it can be a starting point for anyone interested (pls report any progress

).
And it's great to learn that it works with virtuemart. BTW, can you give a live example of this?

k0nan · **Joined:** Fri Apr 13, 2007 2:24 pm **Posts:** 49

elmoch wrote:

Thanks for the feedback, k0nan.
I feel that I lack of knowledge to develop the package as I would like to, but at least it can be a starting point for anyone interested (pls report any progress

).
And it's great to learn that it works with virtuemart. BTW, can you give a live example of this?

well, now it's on a demo site, not yet installed to the customer

i can give you via PM the link to test it

(off course, templating etc etc are very very very very on developing

)

there are little things that don't work, of course we can debate it via IM/Skype etc

just pm me

elmoch · **Posted:** Fri Apr 27, 2007 2:46 pm

Don't worry, I was just curious. Thank you.
In fact I have little time for Joomla lately, but I was thinking of people who had asked about compatibility of JM-Recommend and Virtuemart.
When the site goes online, please let us know, if possible. Thanks.

k0nan · **Joined:** Fri Apr 13, 2007 2:24 pm **Posts:** 49

ok! ^_^

EDIT:
I tested both on a local evinronment and on real online site jmrecommend 1.1beta + virtuemart1.0.10 + opensef rc4 + joomla1.0.12 and it works.
As you know, opensef rc4 is NOT a safe 3d party component, only opensef rc5 beta2 is suitable for live site.

So i tested both on a local evinronment and on real online site jmrecommend 1.1beta + virtuemart1.0.10 + opensef rc5beta2 + joomla1.0.12 and it works only in part: "recommend this page" link take you to the popup, but in the description field is not displayed the page link, so it's useless

Then, i tested both on a local evinronment and on real online site jmrecommend 1.1 RC1 + virtuemart1.0.10 + opensef rc5beta2 + joomla1.0.12 and it works only in part: "recommend this page" link take you to the popup, but in the description field is not displayed the page link BUT it's displayed the home page url!

So till now, i haven't found a solution to keep it working with virtuemart, sorry for the previous post

Joomla! Discussion Forums

Forum rules

Tell a Friend, Send page, Recommend to a Friend. Site + current page

Quick reply

Who is online