Moderator: General Support Moderators
You just thrive on being rude don't you?AmyStephen wrote:Good. You sound very bright. I look forward to your patch.
Too bad this isn't a bug.
I would like to thank you for helping. I really wish you would stop making assertations like this that don't back up. Even better if you didn't go so far out of your way to be rude to someone who is trying to help.AmyStephen wrote:Good. You sound very bright. I look forward to your patch.
Too bad this isn't a bug.
Code: Select all
if (!$itemid)
{
/* Replace this foreach loop
foreach ($items as $item)
{
if (isset($query['view']) && $query['view'] == 'weblink' && isset($item->query['view'])
&& $item->query['view'] == 'category' && isset($item->query['id']) && isset($query['catid'])
&& $query['catid'] == $item->query['id'])
{
// This menu item links to the weblink view but we need to append the weblink id to it.
$itemid = $item->id;
$segments[] = isset($query['catalias']) ? $query['catid'].':'.$query['catalias'] : $query['catid'];
$segments[] = isset($query['alias']) ? $query['id'].':'.$query['alias'] : $query['id'];
break;
}
elseif (isset($query['view']) && $query['view'] == 'category' && isset($item->query['view'])
&& $item->query['view'] == 'category' && isset($item->query['id']) && isset($query['id'])
&& $item->query['id'] != $query['id'])
{
// This menu item links to the category view but we need to append the category id to it.
$itemid = $item->id;
$segments[] = isset($query['alias']) ? $query['id'].':'.$query['alias'] : $query['id'];
break;
}
}
*/
// With this loop
if (isset($query['id']))
{
// I used a for loop; for some reason the foreach was exiting first run in my debugger
for ($i = 0; $i < count($items); $i++)
{
// I convert it to an $item here
$item = $items[$i];
// This parses out the $item->link and looks for an id and compares it to the $query['id']
if ((strpos($item->link, '&id=') ? substr($item->link, strpos($item->link, '&id=') + 4) : '') == $query['id'])
{
// This menu item links to the category view but we need to append the category id to it.
$itemid = $item->id;
$segments[] = isset($query['alias']) ? $query['id'].':'.$query['alias'] : $query['id'];
break;
}
}
}
} // end if (!$itemid)
Thank you, Jeff, that works a treat.jflesher wrote:I think this should solve your problem; let me know so I can report this to the bug reports you have indicated.
Thanks for following up on this. I had come up with my own patch which was shorter but less elegant than yours, and possibly doesn't solve everything yours solves. I don't have any weblinks with more than 2 categories, so I didn't observe how it affects more than the first. I've swapped out mine for yours.jflesher wrote:I have verified that this BUG still exist in 1.5.9; I'm going to update this post till its fixed.
I notice that the bug was closed:jflesher wrote:I have verified that this BUG still exist in 1.5.9; I'm going to update this post till its fixed.
Are you trying to be funny? Are you for real?danieltooop wrote:Hi,
("==") was not typo error or logical error.
Actually ("==") is one of the logical operators, which is used in php. So, i think there is some other error in that code. There might be error on conditions. Check it out.
. 
© 2005 - 2024 Open Source Matters, Inc. All Rights Reserved.
