Banners tracking

[Neow]

Hello,

I just want to notify that I've activated banners tracking (click and impressions) but that didn't work. I have to modify banners models: it never does anything if the number of clicks/impressions is equal to 0. Replacing a few < by <= solved my issue.

In components\com_banners\models\banners.php, around lines 217-226 :

Code: Select all

			// track impressions
			$trackImpressions = $item->track_impressions;
			if ($trackImpressions <= 0 && $item->cid) {
				$trackImpressions = $item->client_track_impressions;
			}

			if ($trackImpressions <= 0) {
				$config = JComponentHelper::getParams('com_banners');
				$trackImpressions = $config->get('track_impressions');
			}

In components\com_banners\models\banner.php, lines 53-61 :

Code: Select all

		if ($trackClicks <= 0 && $item->cid) {
			$trackClicks = $item->client_track_clicks;
		}

		if ($trackClicks <= 0) {
			$config = JComponentHelper::getParams('com_banners');
			$trackClicks = $config->get('track_clicks');
		}