[FIXED] Recent change (rev. 8841) to JUser::getTable() breaks BC

gregdev · **Joined:** Sat Jul 15, 2006 6:27 pm **Posts:** 37

Recent changes (rev. 8841) to JUser::getTable() removed this line:

Code:

$table->load($this->id);

This causes the global $my, as set up in legacy.php, to be empty:

Code:

      $user            =& JFactory::getUser();
      $GLOBALS['my']      = clone($user->getTable());
      $GLOBALS['my']->gid   = $user->get('aid', 0);

Adjusting legacy.php to be like this works:

Code:

      $user            =& JFactory::getUser();
      $GLOBALS['my']      = clone($user->getTable());
      $GLOBALS['my']->load($user->id);
      $GLOBALS['my']->gid   = $user->get('aid', 0);

But, shouldn't JUSer::getTable() return a valid user table for the current user?

Greg

Robin · **Joined:** Thu Aug 18, 2005 10:41 am **Posts:** 15089

Q&T; marking as under review

tcp · **Posted:** Thu Sep 13, 2007 4:05 pm

Confirmed.

Code:

                // Create the user table object
-               $table  =& JTable::getInstance( 'user');
-               $table->load($this->id);
-
+               $table  =& JTable::getInstance( $tabletype);

Johan, would there be any reason why we wouldn't want to load the table if the user object was populated?

Code:

if ( $this->id ) {
  $table->load($this->id);
}

If there is an issue, could we accept an additional arg to getTable() to toggle the loading of data?

tcp

Jinx · **Joined:** Fri Aug 12, 2005 12:47 am **Posts:** 6431

Fixed on SVN.

@Toby : for performance reasons getTable should only return a JTable object. Don't like to add to many functions params, makes the API less KISS.

gregdev · **Joined:** Sat Jul 15, 2006 6:27 pm **Posts:** 37

Thanks.

There is a typo:

Code:

$BLOBALS['my'] = $table->load($user->id);

Should be a G.

Greg

tcp · **Posted:** Thu Sep 13, 2007 6:39 pm

@jinx: botchay. But why is bregdev talkinb about my blobals?

Fixed in Rev 8870

gregdev · **Joined:** Sat Jul 15, 2006 6:27 pm **Posts:** 37

OK. I looked more closely. This bug is not fixed. I guess the B distracted me.

The current code is like this:

Code:

      $user            =& JFactory::getUser();
      $table            = clone($user->getTable());
      $GLOBALS['my']      = $table->load($user->id);
      $GLOBALS['my']->gid   = $user->get('aid', 0);

This line is bad:

Code:

$GLOBALS['my'] = $table->load($user->id);

$table->load($user->id) returns a boolean, not a JTable object.

Something like my original post would work.

Thanks,

Greg

Jinx · **Joined:** Fri Aug 12, 2005 12:47 am **Posts:** 6431

Should be fixed now.

gregdev · **Joined:** Sat Jul 15, 2006 6:27 pm **Posts:** 37

OK now. Thanks.

Joomla! Discussion Forums

Forum rules: Please click here to view the forum rules

[FIXED] Recent change (rev. 8841) to JUser::getTable() breaks BC

Quick reply

Who is online