The Joomla! Forum ™






Post new topic Reply to topic  [ 24 posts ] 
Author Message
PostPosted: Thu Mar 15, 2007 11:10 am 
Joomla! Apprentice
Joomla! Apprentice
Offline

Joined: Thu Aug 25, 2005 11:22 pm
Posts: 20
Having a play with the new menu refactoring (which is v. cool) - if the Search Engine Friendly URLs and Use mod_rewrite are both turned on ... Then the menu appears as http://www.domain.com/menu-name.html

Confirming this correct?


Then... the default content loads several menus : main menu (core), user menu, top menu etc...
If I add the same menu name under main and top menu (ie Introduction) but point to different articles they appear:
main menu link : http://www.domain.com/introduction.html
top menu link : http://www.domain.com/introduction.html

They are separate menus and articles, but the links point to the same article.

Is this a bug?


Last edited by Jinx on Tue Apr 10, 2007 9:26 am, edited 1 time in total.

Top
 Profile  
 
PostPosted: Thu Mar 15, 2007 4:11 pm 
Joomla! Apprentice
Joomla! Apprentice
Offline

Joined: Sat Mar 18, 2006 5:17 pm
Posts: 15
I can confirm this problem. Seems to be a bug indeed. Let's wait what the dev team says about the issue.


Top
 Profile  
 
PostPosted: Thu Mar 15, 2007 5:32 pm 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Sat Aug 20, 2005 12:32 pm
Posts: 1105
Location: Weymouth, UK
http://groups.google.com/group/joomla-d ... 3a45beb293

Core Devs Discussion on this

_________________
Phil Taylor - Full Time Joomla/PHP Expert
Blue Flame IT Ltd.
-- http://fix.myjoomla.com/ Same day commercial fixes for Joomla sites worldwide
-- http://www.phil-taylor.com/


Top
 Profile  
 
PostPosted: Thu Mar 15, 2007 8:02 pm 
User avatar
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 12:06 pm
Posts: 762
Location: Netherlands
Correction Phil: development workinggroup discussion, we don't have a core development group any more ;-)

_________________
Personal blogs can be found on http://JFoobar.org


Top
 Profile  
 
PostPosted: Fri Mar 16, 2007 8:51 am 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Sat Aug 20, 2005 12:32 pm
Posts: 1105
Location: Weymouth, UK
I stand corrected :-)

_________________
Phil Taylor - Full Time Joomla/PHP Expert
Blue Flame IT Ltd.
-- http://fix.myjoomla.com/ Same day commercial fixes for Joomla sites worldwide
-- http://www.phil-taylor.com/


Top
 Profile  
 
PostPosted: Sun Mar 18, 2007 7:16 pm 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Wed Oct 05, 2005 7:25 am
Posts: 1065
Location: Amsterdam
doko wrote:
If I add the same menu name under main and top menu (ie Introduction) but point to different articles they appear:
main menu link : http://www.domain.com/introduction.html
top menu link : http://www.domain.com/introduction.html

They are separate menus and articles, but the links point to the same article.



It is not only the same name, but also "page not found"warnings if this facility is switched on.
Ie.

http://happyhome:82/index.php?Itemid=48 ... m_weblinks
works

Switcing it on gives

http://happyhome:82/index.php/web-links

and creates a 404 error.
This was on 6964 and using FF.

When I do a preview, the homepage is correct, every following page is a 404 error. It seems that the first page is correctly connected to the respective id, but every next page requested gets the mechanism in a twist.

Pieter

_________________
Joomla Bug Squad

Note: Sending me private messages for personal support, without this been requested, would lead to ignoring any of your posts in future!


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 10:12 am 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Technically it can be considered a bug and we could try to implement a failsafe for it so that you cannot create menu items with the same name twice in the same hierarchical level.

But first ask yourselve, is this really something you will be doing ? Taking from a 'static web' perception it would not be possible, you cannot link to mysite/text.html and then have to different text.html right, this is simply because of file name collisions.

So 1.5 also doesn't support this, the only thing we don't have is a failsafe that reminds you when you try to create the same menu item twice.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 10:20 am 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Wed Oct 05, 2005 7:25 am
Posts: 1065
Location: Amsterdam
I agree with you, Jinx. A failsave would be a good idea, especially for the less experienced users.

Tools like Dreamweaver etc. do tell you when checking the html of the site that you made a mistake.
We need to follow the w3c standards of course, but why am I saying this. Everybody knows that ;) .

Pieter

_________________
Joomla Bug Squad

Note: Sending me private messages for personal support, without this been requested, would lead to ignoring any of your posts in future!


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 12:02 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 16, 2005 8:41 pm
Posts: 3745
Location: NRW - Germany
Scenario:
2 Menus, first is called "Department X" and is displayed when choosing the department from the main menu, second is called "Department Y". Both contain the entry "Contact". Baam!! Your routing is killed. This is way worse than the ItemID issue with frontpage...

_________________
god doesn't play dice with the universe. not after that drunken night with the devil where he lost classical mechanics in a game of craps.

Since the creation of the Internet, the Earth's rotation has been fueled, primarily, by the collective spinning of English teachers in their graves.


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 1:26 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Not sure I understand what you mean, if I read it correctly this would be the structure ?

- Departments
    - Departement X
        - Contact
      - Department Y
          - Contact

Correct ?

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 1:40 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 16, 2005 8:41 pm
Posts: 3745
Location: NRW - Germany
No, main menu:
- Some stuff
- Department X (ID = 2)
- Department Y (ID = 3)
- Some other stuff

Departement X menu Module shown when ID = 2 with content:
- Some stuff
- Contact

Departement Y menu Module shown when ID = 3 with content:
- Some stuff
- Contact

Thus, same level, same menu name, same SEF URL.

_________________
god doesn't play dice with the universe. not after that drunken night with the devil where he lost classical mechanics in a game of craps.

Since the creation of the Internet, the Earth's rotation has been fueled, primarily, by the collective spinning of English teachers in their graves.


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 2:46 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Well yes, however I don't consider that a bug. It's more a situtation that could occur but would go against any basic rules of good IA. For example for accessibilities sake how is a blind user going to know the different between 'some stuff' and 'some stuff' ? He will expect it to link to the same content as there is no markup context to differentiate the two.

This discussion kinda ties in what the discussion on the development forum about=http://forum.joomla.org/index.php/topic,140836.0.html routed URL's and internationalisation. The proposed solution there was to add alias capabilities to all content for 1.5. Doing this for the menu manager would also solve this problem.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 3:30 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
Well it actually happens on the main sites.
both the main menu and the search menu have "search"

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 6:44 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
brian wrote:
Well it actually happens on the main sites.
both the main menu and the search menu have "search"


Those are aliases, they link to the same content not to different content. 1.5 has a spefic menu type called an alias to deal with this.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Mar 28, 2007 7:05 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
Didnt spot the alias link I will check that out.

The two searches are slightly different however as one of them displays the modules associated with the news site layout.

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 4:32 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 16, 2005 8:41 pm
Posts: 3745
Location: NRW - Germany
Still, I see a quite huge problem here. It creates a restriction that wasn't there before and if we would take this to the end, we would have to remove the ability to have different menus and just make it one tree, where you can show a part of it in a menu module, like the start and end parameter in mod_mainmenu.

_________________
god doesn't play dice with the universe. not after that drunken night with the devil where he lost classical mechanics in a game of craps.

Since the creation of the Internet, the Earth's rotation has been fueled, primarily, by the collective spinning of English teachers in their graves.


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 5:18 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
Have to agree with you hackwar

I just realised that in one of the sites I manage each main menu item pulls up a new menu for that specific section of the site and in each of those new sections there is a menu item calendar, gallery and document eg

Main menu Items
School, Parents, Pupils, Governers

Section menu Items
News, Calendar, Gallery, Documents

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 5:23 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
So besides pointing out how bad things are, maybe any suggestions to fix these problems ?

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 5:30 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
As you know I am a user not a developer, unlike yourself and Hackwar.

I "guess" one possibiity would be to have the "menu item url" derived from a combination of the menu name and the menu item name
So in my example (or hackwars earlier one)

in my school site it would be
Int he parents menu
Menu item display = Calendar
Menu item url = parent-calendar
In the student menu
Menu item display = Calendar
Menu item url = student-calendar

IE menu item url = $a-$b
$a=menu module name
$b=menu item


Does that help?

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 5:34 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
Or if it is a single menu with parent items then it would be

menu item url = $a-$b
$a=parent menu item
$b=menu item


This method should not require anything extra on the userside apart from maybe a switch to enable/disable this feature

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 6:04 pm 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 16, 2005 8:41 pm
Posts: 3745
Location: NRW - Germany
How about a config parameter for the menues to define a kind of prefix. You set for example "department_x" in that parameter and every item of that menu gets an URL like "/department_x/level_one_item/level_two/etc/".

_________________
god doesn't play dice with the universe. not after that drunken night with the devil where he lost classical mechanics in a game of craps.

Since the creation of the Internet, the Earth's rotation has been fueled, primarily, by the collective spinning of English teachers in their graves.


Top
 Profile  
 
PostPosted: Thu Mar 29, 2007 9:05 pm 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
That would work as well but would require an extra step for the user and i guess more coding.

MY proposal requires nothing extra for the user to do

At the end of the day to a non-programmer like myself both of these options sound like a viable solution to a big problem and that shouldnt be too hard to implement.

Are either of these possible Johan??

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
PostPosted: Tue Apr 10, 2007 9:25 am 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Fixed on SVN, added alias support to menu items.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Tue Apr 10, 2007 11:45 am 
User avatar
Joomla! Exemplar
Joomla! Exemplar
Offline

Joined: Fri Aug 12, 2005 7:19 am
Posts: 8286
Location: Leeds, UK
Thanks, just spotted it on the changelog. Will try to find some time this week to test.

_________________
"Exploited yesterday... Hacked tomorrow"
Blog http://brian.teeman.net/
Joomla Hidden Secrets http://hiddenjoomlasecrets.com/


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 24 posts ] 



Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group