The Joomla! Forum ™

Download

Demo


Board index » Joomla! Official Sites & Infrastructure » Sites & Infrastructure - Feedback/Information » Archived Boards - All boards closed » Quality and Testing - Locked and Archived » Q&T 1.5.x Resolved

Forum rules


Please click here to view the forum rules



Post new topic Reply to topic  Page 1 of 1
  [ 10 posts ] 
  Print view Previous topic | Next topic 
Author Message
Websitemaker
PostPosted: Wed Jun 27, 2007 11:24 am 
Joomla! Enthusiast
Joomla! Enthusiast

Joined: Fri Sep 16, 2005 3:14 pm
Posts: 246
if you Edit search module and try to set ItemID ... its not affecting on frontend ...  there is still "Itemid=1"


You do not have the required permissions to view the files attached to this post.

Last edited by Jinx on Tue Jul 10, 2007 2:06 pm, edited 1 time in total.

Top
 Profile  
 
Robin
PostPosted: Wed Jun 27, 2007 7:42 pm 
User avatar
Joomla! Master
Joomla! Master

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15750
Q&T Note; I have looked at /modules/mod_search/mod_search.php and the helper.php.

The Itemid is stored correctly in the database, and is also retrieved and passed by the helper file.

Looking at where the Itemid is passed too as of that point. I'd say the module seems to be ok.

_________________
Regards Robin

http://www.linkedin.com/in/robinmuilwijk - http://twitter.com/i_robin
Top
 Profile  
 
Jinx
PostPosted: Tue Jul 10, 2007 2:05 pm 
User avatar
Joomla! Champion
Joomla! Champion

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6568
Fixed on SVN.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.joomlatools.eu - Joomla extensions that just work
http://www.nooku.org - Extension development framework for Joomla
Top
 Profile  
 
leadict
PostPosted: Tue Jul 10, 2007 5:43 pm 
Joomla! Guru
Joomla! Guru

Joined: Thu Oct 05, 2006 12:13 am
Posts: 810
Hi Johan,

I would appreciate if you could give us some explanation about the way in which the itemid is taken in those situations in which there is no itemid by default. For example: Links on login module.

There is a thread asking about this on 1.5 Beta 2 board: http://forum.joomla.org/index.php/topic,188052.0.html

Thanks,
(And sorry for the cross post)

_________________
"The skill of writing is to create a context in which other people can think" - Edwin Schlossberg.
Top
 Profile  
 
Jinx
PostPosted: Tue Jul 10, 2007 8:28 pm 
User avatar
Joomla! Champion
Joomla! Champion

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6568
The simple answer is that in case the system cannot find an itemid it will use the id of the default menu item. If he cannot find a default menu item the system should throw an error. This is why for some modules you want to force a certain Itemid so the component is shown in the context of that Itemid and not in the context of the default Itemid.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.joomlatools.eu - Joomla extensions that just work
http://www.nooku.org - Extension development framework for Joomla
Top
 Profile  
 
leadict
PostPosted: Wed Jul 11, 2007 12:33 am 
Joomla! Guru
Joomla! Guru

Joined: Thu Oct 05, 2006 12:13 am
Posts: 810
Thanks Johan. That is what i thought, but i have noticed the behaviour is some different in several contexts. For example:

A) Links on Login module: The url takes the itemid of the current menu item and not the default menu item. So, in this case those links seem context dependant.

B) Links on Latest News module: Generally the url takes the itemid of the default menu item, but in case articles be included in another menu item, the url on latest news module takes the itemid of that menu item.

Thanks for any clarification. I really appreciate it :).

Yours sincerely,
Leandro

_________________
"The skill of writing is to create a context in which other people can think" - Edwin Schlossberg.
Top
 Profile  
 
Jinx
PostPosted: Sat Jul 14, 2007 12:54 pm 
User avatar
Joomla! Champion
Joomla! Champion

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6568
There are indeed some inconsistencies I'm still working on, getting the routing 100% correct is very hard since the architecture was never designed for proper routing in the first place. I need to be creative :) I'll try to write up more about how it works when it's completely done, for the moment I'm focussing on getting the last issues out.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.joomlatools.eu - Joomla extensions that just work
http://www.nooku.org - Extension development framework for Joomla
Top
 Profile  
 
leadict
PostPosted: Sun Jul 15, 2007 7:03 pm 
Joomla! Guru
Joomla! Guru

Joined: Thu Oct 05, 2006 12:13 am
Posts: 810
Thanks Johan for the clarification :).

_________________
"The skill of writing is to create a context in which other people can think" - Edwin Schlossberg.
Top
 Profile  
 
Jinx
PostPosted: Mon Jul 16, 2007 11:53 am 
User avatar
Joomla! Champion
Joomla! Champion

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6568
After review of the force itemid system in modules it has been decided to remove this option. This solution creates architectural issues with the new routing system and is considered the wrong solution. We are currently considering options to create the same behavior in a correct way, not sure if this will be included in 1.5 or not. But we are already removing the force itemid soltuion from all modules to not run into more issues down the road.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.joomlatools.eu - Joomla extensions that just work
http://www.nooku.org - Extension development framework for Joomla
Top
 Profile  
 
leadict
PostPosted: Mon Jul 16, 2007 9:42 pm 
Joomla! Guru
Joomla! Guru

Joined: Thu Oct 05, 2006 12:13 am
Posts: 810
I know this is a complex issue... and this thread means a step forward.

I can't say nothing else but "keep the good work".

_________________
"The skill of writing is to create a context in which other people can think" - Edwin Schlossberg.
Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  Page 1 of 1
  [ 10 posts ] 


Board index » Joomla! Official Sites & Infrastructure » Sites & Infrastructure - Feedback/Information » Archived Boards - All boards closed » Quality and Testing - Locked and Archived » Q&T 1.5.x Resolved

Who is online

Users browsing this forum: No registered users and 1 guest

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group