The Joomla! Forum ™






Post new topic Reply to topic  [ 23 posts ] 
Author Message
PostPosted: Tue Jul 17, 2007 4:43 pm 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
Be Aware! Currently the template installer is not fitted  to install en-GB.tpl_rhuk_milkyway.ini in the back-end (eample, which applies  to any template)

Template designers are waiting for RC before moving to J!1.5. This will not help. :(


Last edited by Jinx on Wed Aug 29, 2007 10:27 pm, edited 1 time in total.

Top
 Profile  
 
PostPosted: Tue Jul 17, 2007 6:31 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15733
Hi walb,

Can you explain in detail what you mean by this, that the installer is not able to install that file?

_________________
Regards Robin

http://www.linkedin.com/in/robinmuilwijk - http://twitter.com/i_robin


Top
 Profile  
 
PostPosted: Tue Jul 17, 2007 9:34 pm 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
This is already tested
http://forum.joomla.org/index.php/topic,181842.0.html
The required coding to copy that file into the admin language folder is missing. :pop


Top
 Profile  
 
PostPosted: Wed Jul 18, 2007 10:20 pm 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
Since I needed myself  to copy en-GB.tpl_rhuk_mytemplate.ini in the back end it is better to provide you with a patch for
libraries\joomla/installer/adapters/template.php

Insert after line 179
Code:
      $this->parent->removeFiles($root->getElementByPath('media'), $clientId);
This line
Code:
      $this->parent->removeFiles($root->getElementByPath('administration/languages'), 1);
Next after line 117-118
Code:
         return false;
      }

Insert
Code:
      // Parse optional tags
           $this->parent->parseLanguages($this->manifest->getElementByPath('administration/languages'), 1);
And after line 52
Code:
      $root =& $manifest->document;
Insert
Code:
   
      $this->manifest =& $manifest->document;
      $this->adminElement =& $this->manifest->getElementByPath('administration');

I hope it's in Louis style :)

What it does not do; install a tpl for the front end.
Which is a pity since Beez contains an untranslated literal 'Standort'
But the language loader is not equipped for that

Regards  ;)


Top
 Profile  
 
PostPosted: Fri Jul 27, 2007 12:41 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Thu Aug 18, 2005 10:41 am
Posts: 15733
Thanks walb,

I'm afraid it did not make the RC1, but hopefully it will for the RC2. Will review the patch and work from there.

_________________
Regards Robin

http://www.linkedin.com/in/robinmuilwijk - http://twitter.com/i_robin


Top
 Profile  
 
PostPosted: Sat Aug 25, 2007 12:06 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
It is indeed an important matter.

AND should be a condition in the template contest.
Waiting for this long-waited-for improvement to the installer...  :)

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Sat Aug 25, 2007 3:34 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
See http://joomlacode.org/gf/project/joomla ... em_id=6703


:pop

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Sat Aug 25, 2007 3:46 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Marked as high priority RC2 won't go out unless it's fixed.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Mon Aug 27, 2007 9:01 pm 
User avatar
Joomla! Ace
Joomla! Ace
Offline

Joined: Mon Dec 05, 2005 10:17 am
Posts: 1367
Location: New Orleans, LA, USA
Fixed committed in revision 8587.

_________________
Rob Schley - Open Source Matters
Webimagery - http://www.webimagery.net/ - Professional Consulting Services
JXtended - http://www.jxtended.com/ - Free and Commercial Joomla! Extensions


Top
 Profile  
 
PostPosted: Mon Aug 27, 2007 9:06 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
JM can you please verify ?

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Tue Aug 28, 2007 6:05 am 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
Will do when back to my desk on Thursday (no access to my joomla-related mail either)

Does it deal with the 2 uses of the language file? i.e. the ini used for template parameters as well as strings in the template index.php  ?

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Tue Aug 28, 2007 6:23 am 
User avatar
Joomla! Virtuoso
Joomla! Virtuoso
Offline

Joined: Fri Sep 02, 2005 10:06 am
Posts: 3168
Location: Solar system - Earth - European Union
So the template contest maybe is up to rc2

_________________
former Q&T WorkGroup Joomla member - Italian Translation Team Member


Top
 Profile  
 
PostPosted: Tue Aug 28, 2007 10:58 am 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
Rev - 8595
The template installer
Installs back and front end en-GB.tpl_mytemplate.ini in the right language folders. OK
De-install OK too.

However for the front end en-GB.tpl_mytemplate.ini is not loaded. NOK. Evidence debug don't display it as loaded.

In libraries\joomla/document/document.php function render added the code:
Code:
      $lang =& JFactory::getLanguage();
      $lang->load( 'tpl_'.$template , JPATH_SITE );
(Maybe there is a better place)
The en-GB.tpl_mytemplate.ini file is now loaded

Now the proof of the pudding.

Created a front end language file en-GB.tpl_beez.ini with bare content:
Code:
YOU ARE HERE:=You are here (we hope):
Replaced in beez index.php the literal
Code:
You are here:
by
Code:
<?php echo JText::_( "You are here:" ); ?>

It outputs 'You are here (we hope):'
Now it is working! ;)


Top
 Profile  
 
PostPosted: Tue Aug 28, 2007 3:48 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
Therefore, if this hack is introduced in trunk, we would indeed be able to include 2 language ini files to install with any template, one for site and one for admin.
That would be great!

Thanks Robs and walb.

@Robs:
you may want to change this to include the 2 language files in your post
http://forum.joomla.org/index.php/topic ... #msg967623

+ I suggest this new functionality to be used for the beez template in trunk so as to show all users how the most complex install.xml looks like.  :)

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Wed Aug 29, 2007 6:27 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Fix added, also added empty ini files to frontend language folder for beez and milkyway.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Aug 29, 2007 6:36 pm 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
Hi JM and Jinx, I reviewed my patch and there's a problem with this:
Quote:
In libraries\joomla/document/document.php function render added the
Code:
      $lang =& JFactory::getLanguage();
      $lang->load( 'tpl_'.$template , JPATH_SITE );
(Maybe there is a better place)
Why? I try to tackle another problem with beez in templates/beez/html\com_poll\poll/default_graph.php  line 35 which contains 3 untranslated literals hits, Prozent and Graph.
I tried JText::_ but it didn't work because it seems en-GB.tpl_beez.ini is loaded to late to render a poll component correct.

A better spot is needed to load the template language file. Any idea?

So far I spotted (at least) the following untranslated language strings in beez:
Code:
 
ADDITIONAL INFORMATIONS=additional informations
BIGGER=bigger
DECREASE SIZE=Decrease size
INCREASE SIZE=Increase size
FONT-SIZE:=Font-size:
GRAPH=Graph
HITS=Hits
JOOMLA! ACCESSIBLE TEMPLATE=Joomla! accessible Template RC 1
JUMP TO ADDITIONAL INFORMATIONS=Jump to additional Informations
JUMP TO MAIN NAVIGATION AND LOGIN=Jump to main navigation and Login
LOGO BEEZ, THREE LITTLE BEES=Logo Beez, Three little Bees
PERCENT=Percent
RESET=reset
REVERT STYLES TO DEFAULT=Revert styles to default
SEARCH, VIEW AND NAVIGATION=Search, View and Navigation
SKIP TO CONTENT=skip to content
SMALLER=smaller
YOU ARE HERE:=You are here:


Top
 Profile  
 
PostPosted: Wed Aug 29, 2007 7:02 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Hi walb,

Function has been added to JDocumentHTML render function before template is rendered. This indeed means that template translations only have effect on the actual main template files, index, component, ... etc. and they don't have any effect on overrides. I'm not sure if we actual need to allow template laguage files to have broader scope ?

PS. Added language strings to beez ini file. Thanks !

Johan

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Wed Aug 29, 2007 9:46 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
Jinx wrote:
Function has been added to JDocumentHTML render function before template is rendered. This indeed means that template translations only have effect on the actual main template files, index, component, ... etc. and they don't have any effect on overrides. I'm not sure if we actual need to allow template laguage files to have broader scope ?


IMO, if possible technically I vote for allowing the broadest scope.

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Wed Aug 29, 2007 10:25 pm 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
We have discussed this, for 1.5 template params and template languages will be limited to template scope and have no effect on overrides. We will gather feedback and decide if and how changes are needed for future versions.

Closing down.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Thu Aug 30, 2007 8:20 am 
Joomla! Guru
Joomla! Guru
Offline

Joined: Thu Aug 18, 2005 9:46 am
Posts: 824
OK. I understand. No overrides for comp's, etc. That could be tagged as a known issue.
BTW this my version of beez index.php which works in conjunction with its beez ini file
Code:
<?php
/**
 * @copyright   Copyright (C) 2005 - 2007 Open Source Matters. All rights reserved.
 * @license      GNU/GPL, see LICENSE.php
 * Joomla! is free software. This version may have been modified pursuant
 * to the GNU General Public License, and as distributed it includes or
 * is derivative of works licensed under the GNU General Public License or
 * other free or open source software licenses.
 * See COPYRIGHT.php for copyright notices and details.
 */

defined('_JEXEC') or die('Restricted access');

$url = clone(JURI::getInstance());
$task = JRequest::getCmd('task');
$showRightColumn = JRequest::getCmd('layout') != 'form' && $task != 'edit';
?>
<?php echo '<?xml version="1.0" encoding="utf-8"?' .'>'; ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $this->language; ?>" lang="<?php echo $this->language; ?>" dir="<?php echo $this->direction; ?>" >
<head>
   <jdoc:include type="head" />

   <link rel="stylesheet" href="templates/<?php echo $this->template ?>/css/template.css" type="text/css" />
   <link rel="stylesheet" href="templates/<?php echo $this->template ?>/css/position.css" type="text/css" media="screen,projection" />
   <link rel="stylesheet" href="templates/<?php echo $this->template ?>/css/layout.css" type="text/css" media="screen,projection" />
   <link rel="stylesheet" href="templates/<?php echo $this->template ?>/css/print.css" type="text/css" media="Print" />
   <link rel="stylesheet" href="templates/<?php echo $this->template ?>/css/general.css" type="text/css" />
   <!--[if lte IE 6]>
      <link href="templates/<?php echo $this->template ?>/css/ieonly.css" rel="stylesheet" type="text/css" />
   <![endif]-->
   <!--[if IE 7]>
      <link href="templates/<?php echo $this->template ?>/css/ie7only.css" rel="stylesheet" type="text/css" />
   <![endif]-->
   <script type="text/javascript" src="templates/<?php echo $this->template ?>/javascript/md_stylechanger.js"></script>
</head>
<body>
   <div id="all">
      <div id="header">
         <h1 id="logo"><img src="templates/<?php echo $this->template ?>/images/logo.gif" border="0" alt="<?php echo JText::_( "Logo Beez, Three little Bees" ); ?>" width="300" height="97" />
         <span class="header1"><?php echo JText::_( "Joomla! accessible Template" ); ?></span>
         </h1>
         <ul>
            <li><a href="<?php $url->setFragment('content'); echo htmlspecialchars($url->toString());?>" class="u2"><?php echo JText::_( "skip to content" ); ?></a></li>
            <li> <a href="<?php $url->setFragment('mainmenu'); echo htmlspecialchars($url->toString());?>" class="u2"><?php echo JText::_( "Jump to main navigation and Login" ); ?></a> </li>
            <li> <a href="<?php $url->setFragment('additional'); echo htmlspecialchars($url->toString());?>" class="u2"><?php echo JText::_( "Jump to additional Informations" ); ?></a> </li>
         </ul>

         <h2 class="unsichtbar"><?php echo JText::_( "Search, View and Navigation" ); ?> </h2>

         <div id="fontsize">
         <script type="text/javascript"><!--
            var size =['<h3><?php echo JText::_( "Font-size:" ); ?></h3><p class="fontsize">']
            var bigger  =['<a href="index.php" title="<?php echo JText::_( "Increase size" ); ?>" onclick="changeFontSize(2);return false;" class="larger"> <?php echo JText::_( "bigger" ); ?></a><span class="unsichtbar"> </span> ']  ;
            var smaller =['<a href="index.php" title="<?php echo JText::_( "Decrease size" ); ?>" onclick="changeFontSize(-2);return false;" class="smaller"> <?php echo JText::_( "smaller" ); ?></a><span class="unsichtbar"> </span> ']  ;
            var reset = ['<a href="index.php" title="<?php echo JText::_( "Revert styles to default" ); ?>" onclick="revertStyles(); return false;" class="reset">  <?php echo JText::_( "reset" ); ?></a></p> '];
            document.write(size);
            document.write(bigger);
            document.write(smaller);
            document.write(reset);
         -->
         </script>
         </div>

         <jdoc:include type="modules" name="user3"  />
         <jdoc:include type="modules" name="user4" />

         <div id="breadcrumbs">
            <p> <?php echo JText::_( "You are here:" ); ?> <jdoc:include type="module" name="breadcrumbs" /></p>
         </div>
         <div class="wrap"> </div>
      </div> <!-- end header -->

<?php if ($this->countModules('user1 + user2 + right + top') && $showRightColumn) : ?>
   <div id="contentarea2">
<?php else : ?>
   <div id="contentarea">
<?php endif; ?>
      <a name="mainmenu"></a>
      <div id="left">
         <jdoc:include type="modules" name="left" style="xhtml" />
      </div> <!-- left -->

      <a name="content"></a>
<?php if ($this->countModules('user1 + user2 + right + top') && $showRightColumn) : ?>
   <div id="main2">
<?php else : ?>
   <div id="main">
<?php endif; ?>

<?php if ($this->getBuffer('message')) : ?>
   <div class="error">
      <h2> Message </h2>
      <jdoc:include type="message" />
   </div>
<?php endif; ?>

   <jdoc:include type="component" />

      </div> <!-- end main or main2 -->

   <?php if ($this->countModules('user1 + user2 + right + top') && $showRightColumn) : ?>
      <div id="right">
      <a name="additional"></a>
      <h2 class="unsichtbar"><?php echo JText::_( "additional informations" ); ?></h2>
      <?php if ($this->countModules('top')) : ?>
      <jdoc:include type="modules" name="top" style="xhtml" />
      <?php endif; ?>

      <?php if ($this->countModules('user1')) : ?>
      <jdoc:include type="modules" name="user1" style="xhtml" />
      <?php endif; ?>

      <?php if ($this->countModules('user2')) : ?>
      <jdoc:include type="modules" name="user2" style="xhtml" />
      <?php endif; ?>

      <?php if ($this->countModules('right')) : ?>
      <jdoc:include type="modules" name="right" style="xhtml"/>
      <?php endif; ?>
      </div> <!-- right -->
   <?php endif; ?>

<div class="wrap"></div>

      <div id="footer">
         <p class="syndicate">
            <jdoc:include type="modules" name="syndicate" />
         </p>
         <p>
            Powered by <a href="http://joomla.org">Joomla!</a>
         </p>

         <div class="wrap"></div>
      </div> <!-- footer -->
   </div><!-- contentarea -->

   </div> <!-- all -->

<jdoc:include type="modules" name="debug" />

</body>
</html>


Top
 Profile  
 
PostPosted: Thu Aug 30, 2007 10:32 am 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
beez

templatedetails.xml is encoded iso-8559-1
Installing language files missing in the xml

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
PostPosted: Thu Aug 30, 2007 11:46 am 
User avatar
Joomla! Champion
Joomla! Champion
Offline

Joined: Fri Aug 12, 2005 12:47 am
Posts: 6566
Fixed xml file encoding.

_________________
Johan Janssens - Joomla Co-Founder, Lead Developer of Joomla 1.5

http://www.nooku.org - multi-lingual content manager and rapid extension development framework for Joomla 1.5
http://www.joomlatools.eu - training, consulting and extension development


Top
 Profile  
 
PostPosted: Fri Oct 19, 2007 12:52 pm 
User avatar
Joomla! Master
Joomla! Master
Offline

Joined: Fri Aug 12, 2005 3:47 pm
Posts: 15407
Location: **Translation Matters**
Solution found for overrides.
See: http://forum.joomla.org/index.php/topic,223890.0.html

No need to hack core...  ;)

_________________
Jean-Marie Simonet / infograf · http://www.info-graf.fr
Multilanguage in 1.7/2.5: http://help.joomla.org/files/EN-GB_mult ... torial.pdf
---------------------------------
Joomla Translation Coordination Team • Joomla! Production Working Group


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 23 posts ] 



Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group