FIXED!! Joomla_1.0.x_to_1.0.8-Stable-Patch_Package Problems

CiPHeR · **Posted:** Sun Feb 26, 2006 2:43 pm

I have noticed on several sites I have upgraded to 1.0.8-Stable-Patch_Package that after the upgrade, once you login, and it doesnt matter as who you login as, it shows "Hi 0" as the greeting (see screen-0.jpg). Now, if I go into the admin section and change the Login/Logout Module to show Name, it will work displaying the correct Name for that user (see screen-1.jpg), but if you switch back to username, it again displays "0" for the username.

(Edit) see post here: http://forum.joomla.org/index.php/topic ... #msg224392

CiPHeR · **Posted:** Sun Feb 26, 2006 3:15 pm

Noticed another problem after upgrading where one site is also running MambelFish (not sure of exact version) but the main site (frontend) gives this error:

Quote:

Call to a member function on a non-object in /components/com_mambelfish/mambelfish.html.php on line 62

and gives this error in the admin (backend) after logging in:

Quote:

Fatal error: Call to undefined function: initsessionadmin() in /administrator/index2.php on line 38

romit · **Posted:** Sun Feb 26, 2006 3:26 pm

You can edit the mod_login.php of joomla and add this to your code,

Code:

if ( $name ) {
   $query = "SELECT name"
   . "\n FROM #__users"
   . "\n WHERE id = $my->id"
   ;
   $database->setQuery( $query );
   $name = $database->loadResult();
} else {
   $name = $my->username;
}

This will fix your problem about the 0 being in the Hi, 0

About your

Quote:

Noticed another problem after upgrading where one site is also running MambelFish (not sure of exact version) but the main site (frontend) gives this error:
Quote
Call to a member function on a non-object in /components/com_mambelfish/mambelfish.html.php on line 62

and gives this error in the admin (backend) after logging in:
Quote
Fatal error: Call to undefined function: initsessionadmin() in /administrator/index2.php on line 38

This may be a compatibilty isuue with mambelfish,
EDIT: Exact version number would be helpfull and Thanks [color=blue]toubkal for this[/color]

CiPHeR · **Posted:** Sun Feb 26, 2006 3:44 pm

Thanks Romit - looking through the source files it looks as though the dev team left that code out of the 1.0.8 patch package and the full package - wonder why? Anyways, your fix did the job! As for MambelFish 1.5 - I reverted back to Joomla 1.0.7, (well the admin files anyways) and still not working, so I am in the process of re-uploading all the core 1.0.7 files now. Will let you know how it turns out.

Jeff

CiPHeR · **Posted:** Sun Feb 26, 2006 5:44 pm

Okay, reverted back to the 1.0.7 core files, ran the Joomla - MambelFish 1.5 patch, problem now fixed

tenaki · **Joined:** Sun Nov 13, 2005 9:46 pm **Posts:** 146

Sorry where in modules/mod_login.php do I put that snippet

pikepace · **Posted:** Sun Feb 26, 2006 8:47 pm

romit wrote:

You can edit the mod_login.php of joomla and add this to your code,

Code:

if ( $name ) {
   $query = "SELECT name"
   . "\n FROM #__users"
   . "\n WHERE id = $my->id"
   ;
   $database->setQuery( $query );
   $name = $database->loadResult();
} else {
   $name = $my->username;
}

This will fix your problem about the 0 being in the Hi, 0

After implementing this code I have a big problem when trying to log out. When signing in or logging out, the url is messed up and I receive an error. The url comes out like this: http://www.site.comindex.php/?
The slash is appended after the .com and this results in an error (there is not site with this url). The only change I made was the suggested code. Did that change work for you?

EDIT: This problem only occurs when logging in or out from the main page. For example, logging in from http://www.site.com leads to this problem, but logging in from http://www.site.com/index.php or any other page of the site with a full url does not display this issue.

pikepace · **Posted:** Sun Feb 26, 2006 8:50 pm

tenaki wrote:

Sorry where in modules/mod_login.php do I put that snippet

You should find the IF statement near line 49 in the referenced file. If you make this change, then please let us know whether you experience the error mentioned in my previous post.

tenaki · **Joined:** Sun Nov 13, 2005 9:46 pm **Posts:** 146

Thank you that works fine, sorry I am not getting the error you are getting

CiPHeR · **Posted:** Sun Feb 26, 2006 9:54 pm

romit wrote:

EDIT: Exact version number would be helpfull

Sorry Romit, I wasnt able to access the version info for MambelFish at the time of that post.

I had been running version MambelFish 1.5 on Joomla 1.0.7 with the MambelFish 1.5 Patch for Joomla 1.0.7.

I reverted back to the 1.0.7 core files for Joomla, re-uploaded the MambelFish 1.5 Patch for Joomla 1.0.7, and everything is working again.

As for the mod_login.php fix (edit - mod_login.php is in your modules folder), it appears the code was removed for the upgrade and full install and should be fixed to this (this is just a snippet of the file):

Code:

// find this section of code:

$registration_enabled    = $mainframe->getCfg( 'allowUserRegistration' );
$message_login          = $params->def( 'login_message', 0 );
$message_logout       = $params->def( 'logout_message', 0 );
$pretext             = $params->get( 'pretext' );
$posttext             = $params->get( 'posttext' );
$login                = $params->def( 'login', $return );
$logout             = $params->def( 'logout', $return );
$name                = $params->def( 'name', 1 );
$greeting             = $params->def( 'greeting', 1 );

// insert the new (well actually old) code shown below in this area ----------------------
// this is the original code from 1.0.7 that was not included in the 1.0.8 patch and full packages

if ( $name ) {
   $query = "SELECT name"
   . "\n FROM #__users"
   . "\n WHERE id = $my->id"
   ;
   $database->setQuery( $query );
   $name = $database->loadResult();
} else {
   $name = $my->username;
}

// Back to original code -------------------------------------------------------

if ( $my->id ) {
// Logout output
// ie HTML when already logged in and trying to logout
   ?>

This will fix the login greeting.

Sebastiaan · **Posted:** Sun Feb 26, 2006 11:29 pm

pikepace wrote:

After implementing this code I have a big problem when trying to log out. When signing in or logging out, the url is messed up and I receive an error. The url comes out like this: http://www.site.comindex.php/?
The slash is appended after the .com and this results in an error (there is not site with this url). The only change I made was the suggested code. Did that change work for you?

EDIT: This problem only occurs when logging in or out from the main page. For example, logging in from http://www.site.com leads to this problem, but logging in from http://www.site.com/index.php or any other page of the site with a full url does not display this issue.

I do not experience this problem, I went to my main joomla install dir (so no index.php.. etc), I also tried from index.php?option=com_frontpage&Itemid=1 and from other pages. Fix works just fine everywhere.
I tried logging in (and out) as a regular user and with my Admin account.

pikepace · **Posted:** Sun Feb 26, 2006 11:51 pm

Sebastiaan wrote:

I do not experience this problem, I went to my main joomla install dir (so no index.php.. etc), I also tried from index.php?option=com_frontpage&Itemid=1 and from other pages. Fix works just fine everywhere.
I tried logging in (and out) as a regular user and with my Admin account.

Thank you Sebastiaan, this must be an interesting problem that is somehow my own fault. I am going to investigate this further and will provide the details if I can determine the cause and solution.

reej · **Posted:** Mon Feb 27, 2006 12:08 am

i placed the original mod_login.php from version 'Joomla_1.0.7-Stable-Full_Package.zip' into the new 1.0.8 modules directory en overwrite the wrong 1.0.8 one.
now everything is working fine!

camos · **Joined:** Thu Aug 18, 2005 2:39 am **Posts:** 1035

This solution should be cleaned up a bit and made sticky. At least until this glitch is rectified by a new release.

Cheers

Tonie · **Joined:** Thu Aug 18, 2005 7:13 am **Posts:** 13249

Will start a new sticky thread today....

sikumbang · **Posted:** Mon Feb 27, 2006 4:31 pm

Quote:

This may be a compatibilty isuue with mambelfish

use this version of mamblefish with no need patched core files
http://forum.joomla.org/index.php/topic,26271.0.html

or wait for new joomfish release within next two week :laugh:

:
http://forum.joomla.org/index.php/topic,41313.0.html

stingrey · **Posted:** Mon Feb 27, 2006 5:09 pm

Before hacking files, suggest you simply change the module param to display name instead of username - until this bug is resolved:
http://forum.joomla.org/index.php/topic ... #msg225261

camos · **Joined:** Thu Aug 18, 2005 2:39 am **Posts:** 1035

Rey, this fix is only technically a hack since the code that is supposed to handle the user ID is actually missing. This means the file will need to be replaced in any event unless that feature was planned to be dropped. Still your solution is much simpler to work with.

Too many late nights with not enough caffein.

Cheers

jal · **Joined:** Fri Feb 17, 2006 8:27 pm **Posts:** 4

stingrey wrote:

Before hacking files, suggest you simply change the module param to display name instead of username - until this bug is resolved:
http://forum.joomla.org/index.php/topic ... #msg225261

Yes, this is of course the simple solution. However, all my site's names are lowercase, one word, and the username the full name. So you'd get 'Hi, johns' instead of 'Hi, John Steed'. I find that ugly.

That said, people saying that the code was just 'left out' are wrong. The assignment of $name is now done within the 'if ($my->id)', but it's not complete, and bugs. I'll post the fix I made soon.

JAL

jal · **Joined:** Fri Feb 17, 2006 8:27 pm **Posts:** 4

CiPHeR wrote:

As for the mod_login.php fix (edit - mod_login.php is in your modules folder), it appears the code was removed for the upgrade and full install and should be fixed to this (this is just a snippet of the file):

Code:

<snip>

This will fix the login greeting.

No, it will not fix it. You should replace the wrong code (like pikepace suggested). In 1.0.8, the setting of $name is correctly moved from just after the parameter retrieval to below the 'if ($my->id)', since it is only used in that if-block. However, instead of copying the code from 1.0.7, in 1.08 ot reads:

Code:

   if ( $name ) {
      $name = $my->username;
   }

That's wrong for two reasons:
1) if $name equals 1, the full name should be displayed, but instead the username is displayed
2) if $name equals 0, $name is not reassigned at all, so that's why it displays 'Hi, 0'. I find it a bit odd that the variable holding the parameter has the same as the variable holding the name ($name), but that's maybe some optimization (minimizing local variables).

So the code shown above (line 49 in mod_login.php), should be replaced by the 1.0.7 code:

Code:

   if ( $name ) {
      $query = "SELECT name"
      . "\n FROM #__users"
      . "\n WHERE id = $my->id"
      ;
      $database->setQuery( $query );
      $name = $database->loadResult();
   } else {
      $name = $my->username;
   }

Then everything works fine.

JAL

CiPHeR · **Posted:** Wed Mar 01, 2006 2:44 am

Hi Jal,

No offence Jal, but if you look at my earlier post, you'll see that's exactly what I have, I just put in part of the original code that was in 1.0.8 mod_login.php with the fix where it should be - it was romit who originally posted the fix, and his suggestion was to "Add" the following code, not replace any code! (although, he never did mention where to add it) I took a look at the original 1.0.7 mod_login, and the 1.0.8 mod_login and they were almost exactly the same - except for the code missing that romit said to add - so I "inserted" the missing code, romit's code, your code, (which was in 1.0.7 mod_login and missing from 1.0.8 ) and it fixed my problem. 8)

romit wrote:

You can edit the mod_login.php of joomla and add this to your code,

Code:

if ( $name ) {
   $query = "SELECT name"
   . "\n FROM #__users"
   . "\n WHERE id = $my->id"
   ;
   $database->setQuery( $query );
   $name = $database->loadResult();
} else {
   $name = $my->username;
}

This will fix your problem about the 0 being in the Hi, 0

CiPHeR · **Posted:** Wed Mar 01, 2006 4:31 am

Jal,

My apologies, after a much more thorough look at both original source files, 1.0.7 and 1.0.8, taking a closer look at my mod_login module in the admin, and an even closer look at your last post, I realized I was still using the Name opposed to Username, but, the version I had still worked (with the if ( $name ) {
$name = $my->username;
} section of code removed. Anyways, sorry for my previous post, and I hope this one helps to clarify and fix this problem!

Code:

// Original Packaged Joomla 1.0.7 eCommerce Edition VirtueMart 1.0.2 mod_login.php starting at line #21

$registration_enabled    = $mainframe->getCfg( 'allowUserRegistration' );
$message_login          = $params->def( 'login_message', 0 );
$message_logout       = $params->def( 'logout_message', 0 );
$pretext             = $params->get( 'pretext' );
$posttext             = $params->get( 'posttext' );
$login                = $params->def( 'login', $return );
$logout             = $params->def( 'logout', $return );
$name                = $params->def( 'name', 1 );
$greeting             = $params->def( 'greeting', 1 );

if ( $name ) {
   $query = "SELECT name"
   . "\n FROM #__users"
   . "\n WHERE id = $my->id"
   ;
   $database->setQuery( $query );
   $name = $database->loadResult();
} else {
   $name = $my->username;
}

if ( $my->id ) {
// Logout output
// ie HTML when already logged in and trying to logout
   ?>
   <form action="<?php echo sefRelToAbs( 'index.php?option=logout' ); ?>" method="post" name="login">
   <?php
   if ( $greeting ) {
      echo _HI;
      echo $name;
   }
   ?>
   <br />
   <div align="center">
      <input type="submit" name="Submit" class="button" value="<?php echo _BUTTON_LOGOUT; ?>" />
   </div>

Code:

// Original Packaged Joomla 1.0.8 (Update and Full) mod_login.php starting at line #36

$registration_enabled    = $mainframe->getCfg( 'allowUserRegistration' );
$message_login          = $params->def( 'login_message', 0 );
$message_logout       = $params->def( 'logout_message', 0 );
$pretext             = $params->get( 'pretext' );
$posttext             = $params->get( 'posttext' );
$login                = $params->def( 'login', $return );
$logout             = $params->def( 'logout', $return );
$name                = $params->def( 'name', 1 );
$greeting             = $params->def( 'greeting', 1 );

if ( $my->id ) {
// Logout output
// ie HTML when already logged in and trying to logout

// this is the section of code to be replaced, from here --------
   if ( $name ) {
      $name = $my->username;
   }
// ------- to here

   ?>
   <form action="<?php echo sefRelToAbs( 'index.php?option=logout' ); ?>" method="post" name="login">
   <?php
   if ( $greeting ) {
      echo _HI;
      echo $name;
   }
   ?>
   <br />
   <div align="center">
      <input type="submit" name="Submit" class="button" value="<?php echo _BUTTON_LOGOUT; ?>" />
   </div>

Code:

// Proposed fix for Joomla 1.0.8 mod_login.php starting at line #36

$registration_enabled    = $mainframe->getCfg( 'allowUserRegistration' );
$message_login          = $params->def( 'login_message', 0 );
$message_logout       = $params->def( 'logout_message', 0 );
$pretext             = $params->get( 'pretext' );
$posttext             = $params->get( 'posttext' );
$login                = $params->def( 'login', $return );
$logout             = $params->def( 'logout', $return );
$name                = $params->def( 'name', 1 );
$greeting             = $params->def( 'greeting', 1 );

if ( $my->id ) {
// Logout output
// ie HTML when already logged in and trying to logout

// this is the fixed code from here -------
   if ( $name ) {
      $query = "SELECT name"
      . "\n FROM #__users"
      . "\n WHERE id = $my->id"
      ;
      $database->setQuery( $query );
      $name = $database->loadResult();
   } else {
      $name = $my->username;
   }  // --------- to here

   ?>
   <form action="<?php echo sefRelToAbs( 'index.php?option=logout' ); ?>" method="post" name="login">
   <?php
   if ( $greeting ) {
      echo _HI;
      echo $name;
   }
   ?>
   <br />
   <div align="center">
      <input type="submit" name="Submit" class="button" value="<?php echo _BUTTON_LOGOUT; ?>" />
   </div>

I have tested this and works okay on my site.

aynscough · **Joined:** Wed Mar 01, 2006 1:11 pm **Posts:** 3

this is all very clever but I have just upgraded two 1.0.7 sites to 1.0.8 - one shows Hi, 0 and the other is correct! Both have identical mod_login code.

Yes, your code will probably force the correct data to be displayed but is it fixing the cause of the problem? - why do some work unmodified? Personally, I think I will just set the offending site to show the name instead of username at the moment as this is none intrusive and actually says Hi, .

Odd one.

sadparamita · **Joined:** Sun Dec 04, 2005 6:51 pm **Posts:** 5

CiPHeR wrote:

Okay, reverted back to the 1.0.7 core files, ran the Joomla - MambelFish 1.5 patch, problem now fixed

I am considering to revert back to using 1.0.7 core files, what is the Mambelfish 1.5 patch?

muratgunes · **Joined:** Sun Feb 26, 2006 12:28 pm **Posts:** 2

and a fix for login re direction; modules/mod_login.php on line 18

the code;

$url = mosGetParam( $_SERVER, 'REQUEST_URI', null );

fixed code

$url = mosGetParam( $_SERVER, 'REQUEST_URL', null );

jal · **Joined:** Fri Feb 17, 2006 8:27 pm **Posts:** 4

aynscough wrote:

this is all very clever but I have just upgraded two 1.0.7 sites to 1.0.8 - one shows Hi, 0 and the other is correct! Both have identical mod_login code.

There are two settings for the greeting, one with 'name' and one with 'username'. See my original post for details. Probably, one of your sites has 'name' enabled, the other one 'username'.

aynscough wrote:

Yes, your code will probably force the correct data to be displayed but is it fixing the cause of the problem? - why do some work unmodified? Personally, I think I will just set the offending site to show the name instead of username at the moment as this is none intrusive and actually says Hi, .
Odd one.

As you can see above, Cipher agrees with me. And yes, it is fixing the problem, and no, I'm not unmodifying anything, as I place the 1.0.7 code at a different location than it was in 1.0.7. Also, setting username to name wasn't an option for me, as I explained in my original post.

Greetings,

JAL

reej · **Posted:** Wed Mar 01, 2006 8:40 pm

The FiXeD GooD Version of the Mod_login BuG

http://www.zwollywood.com/index.php?opt ... info&id=53

aynscough · **Joined:** Wed Mar 01, 2006 1:11 pm **Posts:** 3

Hi Jal

Thanks for taking time to respond.

jal wrote:

There are two settings for the greeting, one with 'name' and one with 'username'. See my original post for details. Probably, one of your sites has 'name' enabled, the other one 'username'.

No, this is not correct - both sites were set to show username. They are both just being setup - the ONLY difference was that one site had just the admin user whereas the site with the problem has a second user..... could that be a pointer to why they behave differently?

jal wrote:

As you can see above, Cipher agrees with me. And yes, it is fixing the problem, and no, I'm not unmodifying anything, as I place the 1.0.7 code at a different location than it was in 1.0.7. Also, setting username to name wasn't an option for me, as I explained in my original post.

What niggles me is history - I was a developer for a large industrial maintenance system which made the source code available to engineers for trouble shooting issues on-site. However what used to happen is the engineers would fix the problems on site and in some case decided that "it would be nice if...." so changed code and DB substantally; often rushed under pressure and so implemented badly or incorrectly and without the knowledge of the development team. This made system support a nightmare and new releases very complicated.

As you need to display the name and not username, I agree that you probably have to make these changes. However for most adminstrators that are wanting "Hi, " then just telling joomla to display "Hi, " will actually display "Hi, ". I am worried that If mod_login is not replaced in the next patch and the fault is found elsewhere then what is going to happen? Are all modules reissued in patches or just the changed ones? If all is replaced, then no worries. If not, then is it just belt-and-braces or are we going to get a new fault with a non standard system?

Anyway, thanks again.

jal · **Joined:** Fri Feb 17, 2006 8:27 pm **Posts:** 4

Hi aynscough,

aynscough wrote:

No, this is not correct - both sites were set to show username. They are both just being setup - the ONLY difference was that one site had just the admin user whereas the site with the problem has a second user..... could that be a pointer to why they behave differently?

Mmmm, that seems strange. I cannot explain that, unfortunately.

aynscough wrote:

What niggles me is history - I was a developer for a large industrial maintenance system which made the source code available to engineers for trouble shooting issues on-site. However what used to happen is the engineers would fix the problems on site and in some case decided that "it would be nice if...." so changed code and DB substantally; often rushed under pressure and so implemented badly or incorrectly and without the knowledge of the development team. This made system support a nightmare and new releases very complicated.

Heheh, that sounds familiair. However, with Open Source projects, the beauty is that bugs can be fixed (and 'stuff that would be nice' programmed) by anyone, and the main developers can choose whether to include that in the main project or not.

aynscough wrote:

As you need to display the name and not username, I agree that you probably have to make these changes. However for most adminstrators that are wanting "Hi, " then just telling joomla to display "Hi, " will actually display "Hi, ". I am worried that If mod_login is not replaced in the next patch and the fault is found elsewhere then what is going to happen? Are all modules reissued in patches or just the changed ones? If all is replaced, then no worries. If not, then is it just belt-and-braces or are we going to get a new fault with a non standard system?

Well, mod_login should be fixed in the next version, I don't doubt it will be. Although the fault indeed may (partially) have orginated elsewhere (I haven't investigated further), but mod_login has to be changed anyway to repair the name/username swap, and the fact that only either is set (resulting in the '0'). So I have less worries than you

.

JAL

PhilTaylor-Prazgod · **Posted:** Fri Mar 03, 2006 11:08 am

http://blog.phil-taylor.com/2006/03/03/ ... ther-bugs/

Joomla! Discussion Forums

Forum rules

FIXED!! Joomla_1.0.x_to_1.0.8-Stable-Patch_Package Problems

Quick reply

Who is online