[FIXED]banned words in contact form blocking all words

[wildside]

edit: Original Subject: banned words in contact form parameters blocking all words

Hi all,

To avoid the spam to my Joomla! sites through the contact forms I have added "http" and "www" to the banned words... in the contact message field parameters.

Spam stopped immediately...But... So did all other mail from the contact form.. On checking this I am getting the message "your email contained banned words" every single time even if the banned word is not in the list set in the parameters...

If I remove all the words from the banned word settings and save I can then go to the front end and use the contact form without error... If there is a word in the banned word area of the contacts parameters then no emails at all are sent... It doesn't seem to matter if the banned word is written in the contact form or not, all attempts to send an email are rejected....

Could anyone else confirm this? Right now I have removed my banned word list and am open to spam again...

Database Version: 5.0.51a-community
Database Collation: utf8_general_ci
PHP Version: 5.2.5
Web Server: Apache/2.2.8 (Unix) mod_ssl/2.2.8 OpenSSL/0.9.7a DAV/2 mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635
Web Server to PHP interface: cgi-fcgi
Joomla! Version: Joomla! 1.5.4 Production/Stable [ Naiki ] 6-July-2008 22:00 GMT
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-GB; rv:1.9) Gecko/2008052906 Firefox/3.0

Clive

[user deleted]

Hi Clive,

Confirmed, after doing a quick test. I'll add it to the bug tracker.

Tracker: http://joomlacode.org/gf/project/joomla ... m_id=11839

[mcsmom]

what happens if you don't put html in the banned list but just use regular words?

[wildside]

Thank you for the confirmation and adding it to the bug tracker... I find the support in this forum excellent....
It is hard sometimes for us non Joomla experts to know whether it is a user error or a bug...

I just tested by adding a random word to the banned word list in the banned text area... I used the word "great" and saved. In the front end trying to send a message that did not have this word in it resulted in an error message... "your email contains banned text"...

Clive

[ircmaxell]

A patch has been attached to the tracker which appears to fix this issue. Please test if possible...

[user deleted]

Clive,

In case you do not have a development environment to apply the patch, let us know so we can attach the altered file instead.

[wildside]

Hi,

I don't have a development environment... My sites are live

If you could attach the file and tell me where to put it I would be grateful.

Clive

[user deleted]

Hi Clive,

File location: components/com_contact/controller.php

See attachment

[wildside]

Hi all,
After uploading the new file I had an odd error whereby the email copy was received but though the success message showed the email was sent but it wasn't received to the email set for the contact us form... This happened a few times so I put the old file back and both emails got sent and received again... I re uploaded the new file and the problem had gone away... I don't know what caused this...

Any way, I then tested and these are the results

Testing with the old file and a banned word entered in the banned text area
Result, all messages are blocked.

Testing with the old file and no word entered into the banned text area.
Result, both the email enquiry and the copy sent and received

Testing the new file with no banned words entered in the banned text area.
Result, both the email enquiry and the copy sent and received

Testing the new file with a word entered in the banned text area but not putting the banned word into the email body.
Result, both the email enquiry and the copy sent and received

Testing the new file with a word entered in the banned text area and adding the banned word to the email body.
Result, mail not sent and error message displayed.. When the page refreshes to give the banned word notice the contact form has disappeared so to get it again you either have to click the back button or the contact us link to get the form again.

I think the error is fixed....

Thank you everyone

Clive

[brad]

Nice work all: http://community.joomla.org/core-team-b ... ation.html and especially Clive, our newest community contributor

[mihu]

DEV Notes; Marked "FIXED" and move to resolved forum.
Fixed in SVN