[SOLVED]Banners self unpublishing

Locked
kjar011
Joomla! Fledgling
Joomla! Fledgling
Posts: 4
Joined: Mon Sep 03, 2007 9:24 pm

[SOLVED]Banners self unpublishing

Post by kjar011 » Wed Sep 05, 2007 6:43 am

Description:
When a banner has a limited number of clicks it becomes unpublished by itself after being displayed once

Reported on:
Joomla 1.5 RC2

Affected functions:
mod_banner - when used for paid advertisements



Steps to replicate:
Change one of the sample text ads from being unlimited in clicks to some number, uncheck the unlimited checkbox

Load the home page - ad will be displayed on right

Reload the home page - The ad that you set to a limited number of clicks will not be displayed, but the rest of the ads will be.

Sorry no live url, internal only server.

Topic / Artifact ID:
Sorry new at this not sure what is meant by artifact id/url

System info:
Mac OSX Server 10.4.10, PHP 5.2.2, MySQL 5.0.24a (just reading off phpinfo script, that's what's listed as Client Version API in the mysql section)

 
User avatar
kelb
Joomla! Guru
Joomla! Guru
Posts: 602
Joined: Mon Oct 02, 2006 3:08 am
Location: Turkey
Contact:

Re: Banners self unpublishing

Post by kelb » Tue Oct 16, 2007 11:24 pm

Still an issue on 9239.
Every soul will taste of death.

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

Re: Banners self unpublishing

Post by ianmac » Tue Dec 11, 2007 10:00 pm

Confirmed Issue 9611.

Ian

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

[PATCH] Re: Banners self unpublishing

Post by ianmac » Wed Dec 12, 2007 5:43 am

Here is a patch - the comparison values were reversed.

Ian
You do not have the required permissions to view the files attached to this post.

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

Re: Banners self unpublishing

Post by ianmac » Wed Dec 12, 2007 9:31 pm

Fixed in SVN.

Ian

tckirami
Joomla! Apprentice
Joomla! Apprentice
Posts: 5
Joined: Tue Dec 11, 2007 6:31 am

Re: Banners self unpublishing

Post by tckirami » Thu Dec 13, 2007 4:32 am

Ads with the unlimited impressions option no longer work, for me at least...
I changed the following :-

Code: Select all

$expire = ($item->impmade >= $item->imptotal);
To this :-

Code: Select all

                        
if ($item->imptotal == 0) {
   $expire = ($item->imptotal >= $item->impmade);
} else {
   $expire = ($item->impmade >= $item->imptotal);
}
It's ugly but it was the quickest way I could think of to get the Ads to work as expected.

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

Re: Banners self unpublishing

Post by ianmac » Thu Dec 13, 2007 5:03 am

okay...  try updating again...  should be fixed.

Ian

tckirami
Joomla! Apprentice
Joomla! Apprentice
Posts: 5
Joined: Tue Dec 11, 2007 6:31 am

Re: Banners self unpublishing

Post by tckirami » Thu Dec 13, 2007 5:11 am

Yeah that looks much better, I wasn't sure if that was really the way to do it but all is good now  8)

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

Re: Banners self unpublishing

Post by ianmac » Thu Dec 13, 2007 3:40 pm

yeah...  sorry...

Can someone confirm the fix?

Then we can get a mod to move this to resolved, I hope.

Ian

tckirami
Joomla! Apprentice
Joomla! Apprentice
Posts: 5
Joined: Tue Dec 11, 2007 6:31 am

Re: Banners self unpublishing

Post by tckirami » Fri Dec 21, 2007 10:54 pm

The fix works for me  8)

User avatar
ianmac
Joomla! Virtuoso
Joomla! Virtuoso
Posts: 4784
Joined: Sat Sep 24, 2005 11:01 pm
Location: Toronto, Canada

Re: Banners self unpublishing

Post by ianmac » Sat Dec 22, 2007 12:35 am

Excellent!

Thanks,

Ian

User avatar
kelb
Joomla! Guru
Joomla! Guru
Posts: 602
Joined: Mon Oct 02, 2006 3:08 am
Location: Turkey
Contact:

Re: Banners self unpublishing

Post by kelb » Mon Jan 07, 2008 1:09 am

fix confirmed, so let's get rid of this one.
Every soul will taste of death.

 

Locked

Return to “Q&T 1.5.x Resolved”