[FIXED] Links to anchor don't work after 1.0.7 to 1.0.9 update

[danimal]

The anchor is not within content, it's in my template, in the footer.

[havshoei]

I installed the fix and it still doesn't work. with core joomla sef or open sef.
i believe this had to do with anchors within content items. my problem is all my anchors redirect me to the home page. they will work on the home page though.

Please note that core SEF only handels anchors that comply with HTML 4, that means only strings matching the pattern "[A-Za-z][A-Za-z0-9:_.-]*"

A link as [href="#5"]  pointing to an anchor [] do not match this pattern as it do not start with a letter "A-Za-z" (upper- or lower case letter in the range A to Z), it starts with a digit.

Change your anchors to comply with the above (e.g. "a5") then it should work.

[added]
I my templete file i do this:

// Page URI
$temp = split('index.php', $_SERVER['REQUEST_URI']);
$link = sefRelToAbs('index.php' . @ $temp[1]);

$head_link = $link . '#to_top';

[danimal]

I installed the fix and it still doesn't work. with core joomla sef or open sef.
i believe this had to do with anchors within content items. my problem is all my anchors redirect me to the home page. they will work on the home page though.

Please note that core SEF only handels anchors that comply with HTML 4, that means only strings matching the pattern "[A-Za-z][A-Za-z0-9:_.-]*"

A link as [href="#5"]  pointing to an anchor [] do not match this pattern as it do not start with a letter "A-Za-z" (upper- or lower case letter in the range A to Z), it starts with a digit.

Change your anchors to comply with the above (e.g. "a5") then it should work.

[added]
I my templete file i do this:

// Page URI
$temp = split('index.php', $_SERVER['REQUEST_URI']);
$link = sefRelToAbs('index.php' . @ $temp[1]);

$head_link = $link . '#to_top';

You are referring to the site i had posted above, the site is currently now on their server and the anchor in question follow the rules, it is called "top".

the anchors in the nav have been renamed as well to none numerical names
(the script i used as the starting point i found on the moo/fx forums had them named that way.)

I know how to use anchors, the problem is in joomla. If i turn off sef they work, if I turn them on they dont.

But please people, keep trying to poke holes in my code instead of looking at the real problem. Joomla!
It has been doing this since version 1.0.8. and i even had to toss a nav i made into an iframe to work around the problem in the last joomla site i did about 4 weeks ago.

[danimal]

Anyways,

I give up. I am ripping the anchor out of this site, and unsubscribing from this thread.

[tijs]

The modified /mambots/content/mossef.php file in SVN attached.

I can confirm that this fix works for me, using 404SEF. Thanks a lot, this was a nasty bug!!!

[eric]

Thanks for posting the fix.. although I'm still having some trouble.  Maybe it has something to do with the fact that I'm using SEF Advance?

When I turn off SEF, the anchors work fine.  When I turn on SEF, the anchors don't show in any of the links.

For example, if my page is located here

http://www.domain.com/thing1/thing2/document/

The HTML for the anchor links is written like this in the editor:

Code: Select all

<a href="#program">The Program</a><br />
<a href="#schedule">Program Schedule</a><br />

However the address that they link to are all the same (without the anchor as part of the link) like this:
http://www.domain.com/thing1/thing2/document/

Any ideas? suggestions?

[stingrey]

Thanks for posting the fix.. although I'm still having some trouble.  Maybe it has something to do with the fact that I'm using SEF Advance?

What happens if you use Core SEF.

If it works with Core SEF then it is more likely the problem may be in SEF Advance - but I have no way of testing this myself and if you believe it is an issue with SEF Advance you shoudl contact the developer.

[eric]

What happens if you use Core SEF.

I set up a clean test install of Joomla with the sample data, created a new content item with anchors, and applied the fixed mossef.php file.  Anchors worked fine with and without core SEF enabled.. I installed the latest version of SEF Advance and had the same problem as I described earlier.

Thanks for your help, I'll contact Emir.

[castus]

Thanks for the bug fix it seems to have worked a treat for my content items. However like danimal says if it is in the template, then it doesn't work, as is the case with me.

I have a link in a menu which is for accessibility and skips the content for people using screen readers.

This link isn't working with the fix, and is showing as http://www.castus.co.uk/#content rather than showing the page that you're on with #content at the end.

[friesengeist]

This link isn't working with the fix, and is showing as http://www.castus.co.uk/#content rather than showing the page that you're on with #content at the end.

Hi castus,

could you please post the relevant code that prints out the anchor? Without knowing what exactly you do it is hard to find a bug

Best,
Enno

[castus]

Umm well, as all of the above posters I had a problem with my anchors when using SEF.

Now since applying the patch that stingrey posted it is now fine again.

But when I set up a menu link (link/url) with #content in it, it doesn't work.

It goes to the site root/#anchor.

I hope this makes more sense and thanks for the help.

[castus]

Has anyone looked into this further?

[stingrey]

Has anyone looked into this further?

Please note this issue has not been examined as it differed from teh original report of this thread and this thread is now in the 'Resolved' forum which means it is less visible to the team.

Please start a new thread in the `Joomla! 1.0.x_Q&T` forum to ensure that we can followup on this issue.

[castus]

Ok, thanks.

[72dpi]

Great Fix Stingrey,

Thanks for your efforts!

Cheers, works PERFECT!

[josey]

can anyone confirm that this new file works with 1.0.10?


thanks

[tijs]

Yes it works for me.

[josey]

cool, you're quick.

when i replaced the file, i just get redirected to the top of the page, however not to the home anymore. i'll try reestablishing my anchors. i am using sef advance, i don't think that sould affect anything though.

any suggestions appreciated

[tijs]

Make sure you have relative links and anchors. I use 404SEF and it works there. Are you doing a full upgrade to 1.10 or are you just trying to make the anchors work on an old version? You should update to 1.10 anyway...

[josey]

i see now above that eric had conflicts when using sef advance too. i just pm him. but what do your relative links look like? index.php?option=com_content&task=view&id=1&Itemid=2


thanks

[mont]

I have just added the "patched" file to a clean install of 1.0.10 downloaded today, which is showing the same symptoms.

No success. I have unpublished the SEF mambot to solve the problem.

[j00p]

We are also still  having the same problem even after applying the modified patch in /mambots/content/mossef.php.

Using J! 1.0.10, and 404SEF. I also tried with 404SEF turned off and still no luck.

What else could be the problem?

[kopoba]

Thanks stingrey, to me the anchor navigation works fine with modified mossef, 404SEF and accessible Joomla 1.0.11a. Finally!

[yourheiness]

Has anyone found a fix for this yet?  I tried installing the fix above (mossef.php) and it did not work either.

[Dan2]

From a quick look at my source code the problem was -- this creates a base for all links meaning anchors won't work. I don't know a fix for your specific problem, but if you download your source, remove this line, and throw in a browser, the anchors will then work fine... so that may be a starting point.

[yourheiness]

Dan,

Thanks for the reply.  Forgive me for being ignorant but what to you mean my "throw in a browser".  Do you mean to define the browser (I.E.) in the code?

[marlar]

I have the same problem. The fix included in this thread does not help. But Dan2 has put me in the right direction. There surely is a base href in the template, but not inserted by me!

It is inserted on line 193 in frontend.php. If I comment out the line, the anchors work perfectly.

Now I will se if it has any sideeffects.

Does anyone know if the base href is needed at all?

[marlar]

Yes, it is very much needed!

SEF doesn't work if this line is removed. Get just garbled text.

Now, this is bad: with base href, anchors doesn't work. Without base href, nothing works.

Seems to be a major design flaw in the sef built into Joomla 

[castus]

Does adding the following into your template work?

Code: Select all

<?php
// Page URI
$temp = split('index.php', $_SERVER['REQUEST_URI']);
$link = sefRelToAbs('index.php' . @ $temp[1]);
?>
<a href="<?php  echo $link; ?>#content" class="caccess">Skip to Content</a>

[marlar]

No, unfortunately not. The anchor problem is all around, not just on the frontpage.

Besides, I have discovered that it gets even worse with JoomFish because the language specifation is added after the anchor, like

#anchor/lang,en_GB/

I don't want to spend more time on this, so I just disable SEF. Standard SEF isn't that useful anyway.