[LOW:FIXED: 1.0.11] Bannerupload broken

Locked
nico haase
Joomla! Fledgling
Joomla! Fledgling
Posts: 2
Joined: Tue Aug 29, 2006 12:37 pm
Contact:

[LOW:FIXED: 1.0.11] Bannerupload broken

Post by nico haase » Tue Aug 29, 2006 12:44 pm

Description:
Bannerupload broken in Joomla 1.0.11. A direct upload through the button "upload" in the components toolbar is not possible because the popup re-sets the directory to ''.

Reported on:
1.0.11

Affected functions:
Bannerupload of com_banner

Related files:
administrator/popups/uploadimage.php

Steps to replicate:
Adminpanel, click components, banners, manage banners, upload. Try to upload an image and open it with the banner-management.

Proposed fix(es):
administrator/popup/uploadimage.php, line 75 following, change

Code: Select all

if ( $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
	$directory 	= '';
}
to

Code: Select all

if ( $directory != 'banners' && $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
	$directory 	= '';
}
System info:
Joomla! 1.0.11 Stable [ Sunbow ] 28 August 2006 20:00 UTC
Last edited by Robin on Mon Oct 16, 2006 12:54 pm, edited 1 time in total.

User avatar
Robin
Joomla! Master
Joomla! Master
Posts: 15753
Joined: Thu Aug 18, 2005 10:41 am

Re: Bannerupload broken

Post by Robin » Tue Aug 29, 2006 12:49 pm

[TAGGED: Q&T] Status > Under Review

User avatar
infograf768
Joomla! Master
Joomla! Master
Posts: 18685
Joined: Fri Aug 12, 2005 3:47 pm
Location: **Translation Matters**

Re: [UNDER REVIEW: 1.0.11] Bannerupload broken

Post by infograf768 » Tue Aug 29, 2006 1:17 pm

What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php
Jean-Marie Simonet / infograf · http://www.info-graf.fr
---------------------------------
ex-Joomla Translation Coordination Team • ex-Joomla! Production Working Group

nico haase
Joomla! Fledgling
Joomla! Fledgling
Posts: 2
Joined: Tue Aug 29, 2006 12:37 pm
Contact:

Re: [UNDER REVIEW: 1.0.11] Bannerupload broken

Post by nico haase » Tue Aug 29, 2006 1:24 pm

infograf768 wrote: What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php
Yes, thats alright, I also get this. The check for directories is done before banners is described as a special case. So this second check always falses.

User avatar
infograf768
Joomla! Master
Joomla! Master
Posts: 18685
Joined: Fri Aug 12, 2005 3:47 pm
Location: **Translation Matters**

Re: [UNDER REVIEW: 1.0.11] Bannerupload broken

Post by infograf768 » Tue Aug 29, 2006 1:36 pm

@nico

I confirm your hack works. I don't know if it is asecurity problem though
Jean-Marie Simonet / infograf · http://www.info-graf.fr
---------------------------------
ex-Joomla Translation Coordination Team • ex-Joomla! Production Working Group

User avatar
Robin
Joomla! Master
Joomla! Master
Posts: 15753
Joined: Thu Aug 18, 2005 10:41 am

Re: [UNDER REVIEW: 1.0.11] Bannerupload broken

Post by Robin » Tue Aug 29, 2006 1:49 pm


User avatar
Predator
Joomla! Ace
Joomla! Ace
Posts: 1827
Joined: Wed Aug 17, 2005 10:12 pm
Location: Germany-Bad Abbach
Contact:

Re: [ADDED TRACKER: 1.0.11] Bannerupload broken

Post by Predator » Thu Aug 31, 2006 2:41 pm

Fixed in SVN
The "Humor, Fun and Games" forum has  more than 2500 Posts, so why not build a "Humor, Fun and Games Working" Group?
.....
Malicious tongues say we have this WG right from the start, they call it core team :D

User avatar
Robin
Joomla! Master
Joomla! Master
Posts: 15753
Joined: Thu Aug 18, 2005 10:41 am

Re: [ADDED TRACKER: 1.0.11] Bannerupload broken

Post by Robin » Thu Aug 31, 2006 8:23 pm

Hi,

I will be updating all Q&T topics tomorrow. I will add fixes to the known issue list as well.

Regards Robin

User avatar
Robin
Joomla! Master
Joomla! Master
Posts: 15753
Joined: Thu Aug 18, 2005 10:41 am

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by Robin » Mon Oct 16, 2006 12:55 pm

Artifact (http://forge.joomla.org/sf/go/artf5756?nav=1) has been fixed for next release, closing topic as FIXED, moving to Resolved.

Jellocat
Joomla! Apprentice
Joomla! Apprentice
Posts: 36
Joined: Fri Sep 02, 2005 11:15 pm

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by Jellocat » Sun Aug 19, 2007 10:39 pm

I'm using  1.0.13 and the fix reported here above is in place in the uploadimage.php but it's still broken. When I try to upload a new image for a banner I get the following error:

Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator, webmaster@pizzaanyone.com and inform them of the time the error occurred, and anything you might have done that may have caused the error.

More information about this error may be available in the server error log.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

I've chmoded the directories to 777 but that didn't help. Any ideas??

User avatar
Robin
Joomla! Master
Joomla! Master
Posts: 15753
Joined: Thu Aug 18, 2005 10:41 am

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by Robin » Sun Aug 26, 2007 6:54 pm

Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.

Jellocat
Joomla! Apprentice
Joomla! Apprentice
Posts: 36
Joined: Fri Sep 02, 2005 11:15 pm

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by Jellocat » Sun Aug 26, 2007 11:09 pm

RobInk wrote: Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.
Newbie here - how do I adjust the php memory?

User avatar
infograf768
Joomla! Master
Joomla! Master
Posts: 18685
Joined: Fri Aug 12, 2005 3:47 pm
Location: **Translation Matters**

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by infograf768 » Mon Aug 27, 2007 6:24 am

Jellocat wrote:
RobInk wrote: Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.
Newbie here - how do I adjust the php memory?
Is'nt it through php.ini ?
Jean-Marie Simonet / infograf · http://www.info-graf.fr
---------------------------------
ex-Joomla Translation Coordination Team • ex-Joomla! Production Working Group

cordelia
Joomla! Fledgling
Joomla! Fledgling
Posts: 2
Joined: Fri Oct 05, 2007 7:31 pm

Re: [LOW:FIXED: 1.0.11] Bannerupload broken

Post by cordelia » Fri Oct 05, 2007 7:44 pm

php.ini:

In this section the runtime configuration parameters are examined in depth as far as phpWebSite is concerned.

Caution Note that setting the configuration parameters in the php.ini file will affect all the other php applications on the same server. A missconfiguration in one of these values will torpedo your whole site not to mention phpWebSite.

Warning As noted with the other two ways of making these changes you should only pick one of these and use it alone.
The nose of a mob is its imagination. By this, at any time, it can be quietly led.
marine beneficial association


Locked

Return to “Q&T 1.0.x Resolved - Archived”