Page 1 of 1

[LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Tue Sep 26, 2006 4:15 pm
by vampmaster
Hello.

I've just made the upgrade to 1.0.11 last week and now i have a big problem. When I put a link to a mms:// site, it wont do it. It used to but now it sends me to http://www.universal1460.com/mms:// instead of mms:...

it seems it's not recognizing the mms:// as a valid protocol (i know some of us don't like windows but that is taking things to the next level).

Thanks,

Elliot J. Balanza

Re: mms:// is not resolving on the menus.

Posted: Wed Sep 27, 2006 2:06 pm
by Robin
Hi Elliot,

Can you provide me with a valid mms url so I can test this?

Thanks and regards, Robin

Re: mms:// is not resolving on the menus.

Posted: Wed Sep 27, 2006 5:01 pm
by vampmaster
mms://65.167.217.30:81/envivo
that is a valid mms addy.

go to http://www.universal1460.com/index.php, if you click on the girl on the right side that says "Señal en vivo" you will be able to hear the station.

if you try the señal en vivo from the left pane (main menu) you will notice it opens a new window and adds the http://www.universal1460.com/ to the mms command.

I'm working on the top menu with a forwarder right now.

Thanks for your support.

EJB

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 9:23 am
by Robin
Thanks for the url. I just tested it and see that the live_site is added to the link. I'll have to do some digging and furher testing, if this is a bug, I'll move the topic to our Q&T forum and take it from there.

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 11:58 am
by vamba
Issue confirmed also in svn 5190 [1.0.12]
live test site here http://test.jmovies.eu/index.php

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 1:45 pm
by Robin
Thanks Marco, for testing this as well.

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 1:59 pm
by vamba
;)
Unfortunally no much free time for Q&T
....but when possible to be helpfull........ i'm here and ready to help

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 4:36 pm
by vampmaster
so just for my information, I should post it to q&t or what should I do?.

Elliot J. Balanza

Re: mms:// is not resolving on the menus.

Posted: Fri Sep 29, 2006 7:58 pm
by Robin
Hi Elliot,

I'll move the topic to Q&T so we can review this and determine if this is a bug or not.

Re: [LOW:UNDER REVIEW:1.0.11] mms:// is not resolving on the menus.

Posted: Wed Oct 04, 2006 6:53 pm
by vampmaster
So has anyone have had the chance to verify this?

Vamp

Re: [LOW:UNDER REVIEW:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Oct 05, 2006 5:51 am
by Robin
So far it's been verified by at least one other Q&T member. I'll need to check his comments on this and take it from there. Thanks for your patience.

Re: [LOW:UNDER REVIEW:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Oct 26, 2006 7:16 am
by RobS
I think that this is going to be another easy fix.  Try this, edit includes/sef.php.  Look for line ~530 that will look like the first section of code below and modify it to look like the second section of code.  Then try to create a link of mss:// type and see if it works correctly.  I would appreciate it if someone running OpenSEF or something like that could test this to make sure it doesn't break those components.  I tested it with core SEF and it seemed to work fine. 

Code: Select all

// array list of non http/https	URL schemes
$url_schemes 	= explode( ', ', _URL_SCHEMES );
$url_schemes[] 	= 'http:';
$url_schemes[] 	= 'https:';
Change it to:

Code: Select all

// array list of non http/https	URL schemes
$url_schemes 	= explode( ', ', _URL_SCHEMES );
$url_schemes[] 	= 'http:';
$url_schemes[] 	= 'https:';
$url_schemes[] 	= 'mms:';

Re: [LOW:UNDER REVIEW:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Oct 26, 2006 8:45 am
by Robin
Rob,

I installed OpenSEF 2.0.0. RC5 SP2 and changing looking at the newly created menu item with mms link I get the following with OpenSEF enabled:

http://localhost/joomla-dev-10/mms://65 ... :81/envivo

Is was indeed working correct with Core SEF. Going to have a look at the OpenSEF files if I can find an explanation to this.

Re: [LOW:UNDER REVIEW:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Oct 26, 2006 9:09 am
by Robin
Hi,

If you look at OpenSEF file /administrator/components/com_sef/sef.functions.php you find code at line ~422:

Code: Select all

				} else if ( ( strpos( $string, 'http' ) !== 0 )
					&& ( strpos( $string, 'https' ) !== 0 )
					&& ( strpos( $string, 'ftp' ) !== 0 )
					&& ( strpos( $string, 'file' ) !== 0 )
					&& ( strpos( $string, 'mailto' ) !== 0 )
					&& ( strpos( $string, 'javascript' ) !== 0 ) ) {
Adding the following line also solves the issue of adding live_site to the mms link in OpenSEF:

Code: Select all

					&& ( strpos( $string, 'mms' ) !== 0 )
Question now is, do we go ahead with this fix? If you ask me we should. But...look at the url prefixes in Opensef (ftp, file etc), should we add those as well? And not just mms?

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Tue Nov 14, 2006 1:34 pm
by Robin
Q&T Note; bug confirmed and added to tracker; http://forge.joomla.org/sf/go/artf6752?nav=1

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 3:29 am
by Predator
I will add mms to OpenSEF and would suggest to add the others to Joomla! sef as well, did add those due to some user requests which have those links and no probs reported since months.

Will add now first mms to SVN, for the rest some more thoughts or feedbacks ;)

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 6:56 am
by Robin
Marko,

The ftp, mailto and file look very common to me so I see no reason myself to add them to the Joomla! sef file. Anyone else has an opinion on this?

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 12:57 pm
by friesengeist
Marko, I've nothing against adding it. Actually, it's already there, in joomla.php, line 107.

Code: Select all

// Non http/https URL Schemes
$url_schemes = 'data:, file:, ftp:, gopher:, imap:, ldap:, mailto:, news:, nntp:, telnet:, javascript:, irc:';
DEFINE( '_URL_SCHEMES', $url_schemes );

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 1:12 pm
by Predator
friesengeist wrote: Marko, I've nothing against adding it. Actually, it's already there, in joomla.php, line 107.

Code: Select all

// Non http/https URL Schemes
$url_schemes = 'data:, file:, ftp:, gopher:, imap:, ldap:, mailto:, news:, nntp:, telnet:, javascript:, irc:';
DEFINE( '_URL_SCHEMES', $url_schemes );
Funny the guy who add it there missed the sef.php :) , shall i add all to the sef.php?

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 1:48 pm
by friesengeist
Predator wrote: Funny the guy who add it there missed the sef.php :) , shall i add all to the sef.php?
Hugh? It's already in there, in sef.php :)

Code: Select all

$url_schemes 	= explode( ', ', _URL_SCHEMES );
No need to define it twice ;)

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 1:56 pm
by Predator
Ah missed that :D so better to add mms there instead of adding it to the sef.php.

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 2:02 pm
by Predator
Ok added mms in joomla.php line 106

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 4:27 pm
by miki89
Tested the fix and it works ;)

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 4:32 pm
by RobS
Thanks guys, sorry for pointing you in the wrong direction Marko  :-[

I will close the artifact now that it has been tested.

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Thu Nov 16, 2006 4:49 pm
by Predator
RobS wrote: Thanks guys, sorry for pointing you in the wrong direction Marko  :-[

I will close the artifact now that it has been tested.
No was ok to point me in the wrong direction i can change it now also in OpenSEF by using _URL_SCHEMES there, totally forgot this DEFINE part in the joomla.php :D

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Fri Nov 17, 2006 7:11 am
by RobS
Q&T Note; Status> Fixed for next Release.

Moving to Resolved sub-forum.

Re: [LOW:TRACKER 6752:1.0.11] mms:// is not resolving on the menus.

Posted: Tue Dec 12, 2006 9:54 pm
by vampmaster
Thanks for your efforts guys.

Vamp