[KNOWN ISSUE/LIMITATION] Component installation doesn't fail
Posted: Sat Aug 26, 2006 6:00 pm
I was developing a new component, and did a mistake in the xml file writing twice the same file.
The function that install the files fails, but no error is reported and the installation completes "successfully".
I checked the code and found that in the file
administrator\components\com_installer\component\component.class.php
in the function install(...), on line 75 there is:
So the installation fails only if there is a problem with main files, but it doesn't if the error occurs in images, administration/files or administration/images.
I think that the code should be changed to something like
The function that install the files fails, but no error is reported and the installation completes "successfully".
I checked the code and found that in the file
administrator\components\com_installer\component\component.class.php
in the function install(...), on line 75 there is:
Code: Select all
// Find files to copy
if ($this->parseFiles( 'files' ) === false) {
return false;
}
$this->parseFiles( 'images' );
$this->parseFiles( 'administration/files','','',1 );
$this->parseFiles( 'administration/images','','',1 );
I think that the code should be changed to something like
Code: Select all
// Find files to copy
if ($this->parseFiles( 'files' ) === false ||
$this->parseFiles( 'images' ) === false ||
$this->parseFiles( 'administration/files','','',1 ) === false ||
$this->parseFiles( 'administration/images','','',1 ) === false)
{
return false;
};