Invalid XHTML in mod_banners when SWF is showing

[intermike]

modules/mod_banners/helper.php : 121

Original (v.1.5.8-1.5.9):

Code: Select all

$html ="<object classid=\"clsid:D27CDB6E-AE6D-11cf-96B8-444553540000\" codebase=\"http://fpdownload.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,0,0\" border=\"0\" width=\"$width\" height=\"$height\">
<param name=\"movie\" value=\"$imageurl\"><embed src=\"$imageurl\" loop=\"false\" pluginspage=\"http://www.macromedia.com/go/get/flashplayer\" type=\"application/x-shockwave-flash\" width=\"$width\" height=\"$height\"></embed>
</object>";

Proposing:

Code: Select all

$html ='<object style="border:0;" width="'.$width.'" height="'.$height.'" type="application/x-shockwave-flash" data="'.$imageurl.'">
    <param name="movie" value="'.$imageurl.'" />
    <param name="loop" value="true" />
    <param name="menu" value="false" />
</object>';

Working: Mozzila, IE6, Opera

[bt-t]

Will this proposal also work if we use double quote (") as the outer quote and single quote (') as th inner quote? Please help! Thanks in advance...