authentication.php does not trigger onUserAuthorisation

[mdobrinic]

In file
libraries/joomla/user/authentication.php
the public static function authorise() does not trigger onUserAuthorisation for user,authentication plugins.
This is because the plugins are not imported correctly.

Current code:

Code: Select all

	public static function authorise($response, $options = array())
	{
		// Get plugins in case they haven't been loaded already
		JPluginHelper::getPlugin('user');
		JPluginHelper::getPlugin(‘authentication');
		$dispatcher = JDispatcher::getInstance(); 
		$results = $dispatcher->trigger('onUserAuthorisation', array($response, $options));
		return $results;
	}

New code should be JPluginHelper::importPlugin() instead of getPlugin(), so the new function should look like this:

Code: Select all

	public static function authorise($response, $options = array())
	{
		// Get plugins in case they haven't been loaded already
		JPluginHelper::importPlugin('user');
		JPluginHelper::importPlugin('authentication');
		$dispatcher = JDispatcher::getInstance(); 
		$results = $dispatcher->trigger('onUserAuthorisation', array($response, $options));
		return $results;
	}

Can you please update this in the trunk?

Thanks!

Mark Dobrinic

[oc666]

Hey Mark
I've just updated the events docs: http://docs.joomla.org/Plugin/Events/User

Can you please open bug tracker and give example to your code change, for helping to test it before commit to trunk? You can do it on the bug tracker for 2.5: http://joomlacode.org/gf/project/joomla ... r_id=11410

Is it reproduce on 3.0.x also?

Thanks