$document->setMetaData creates duplicate meta data tags

[hotnuts21]

I have found that when using setMetadata to alter the meta tags of a custom component, then it creates 2 instances of the actual meta tag. This is true for most but not all tags. I have tried with default meta tag field empty and still the same result.

Here are the tags and what happens

Code: Select all

$document->setMetadata('Description', $this->image->title); //-results in two meta description tags the new one and the default
$document->setMetadata('Generator', 'generator tag test'); //- results in two meta generator tags the new one and the default joomla one
$document->setMetadata('Keywords', 'Keywords'); // - results in two meta keywords tags, the new one and the default joomla

$document->setMetadata('robots', 'robots');   //- Replaces robots tag as it should
$mainframe->setPageTitle($this->image->title); //- creates custom title as it should
 

[rayge]

Hmm yeah I see that too. Hopefully someone can tell us what to modify to fix that. looks like the function is in libraries/joomla/document/document.php

[hotnuts21]

Shall I post this as a proper bug in the bug tracker?

[rayge]

THat is A GREAT IDEA. Yes Id say go for it!

[hotnuts21]

Done

http://joomlacode.org/gf/project/joomla ... m_id=12146

[rayge]

Kewl!

Im gonna assume that it builds out an array rather than a string thats why its not replacing the variables.

[mmaison]

Please see my answers on the tracker.

I'm not sure why at the moment this is done this way but I'll find out !

[ircmaxell]

Basically, the third paramter (http_equiv) controls which array is used. Look at the method on line 396 of /libraries/joomla/document/document.php This controls whether or not the first variable passed to it is the name, or the http-equiv value..

For example:
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="robots" content="index, follow" />
<meta name="keywords" content="..." />
<meta name="description" content="..." />
<meta name="generator" content="Joomla! 1.5 - Open Source Content Management" />

[AmyStephen]

Hotnuts21 and rayge -

I was looking at Mickael's patch, trying to figure out how I could validate it, as a tester, and discovered this thread was documented in the report.

Would the two of you please download and apply this patch and see if it fixes the problem you have identified? Also, please note your testing results in the report.

Thanks, Mickael, for the fix and, in advance, to the two of you for testing it.

Amy

[hotnuts21]

I will be able to test this week and provide feedback.

Sorry for the delay
Paul

[Natasha111]

I am having the same problem and for this site http://www.dominguezpublicidad.com, I'm having 7 duplicated meta descriptions . I come out on the first and second page of Google for some keywords and don't want to be penalized,


how do I fix this? Was this patch successfully tested ? I have no idea how to implement it.

Thank you.


Natalia

[hotnuts21]

If you follow the links to the tracker you can see it was succesfully tested before I had a chance to post my own results.

From what I can see it has been committed to 1.5.7 because the bug appears to be gone in the latest version!!

[mmaison]

You're right, the patch has been included in the latest version.
Now setMetaData is flexible on the case. If you first set a meta "Keywords", you can change it using "keywords", it won't create 2 instances.
Then setMetaData is now able to call directly "setGenerator" or "setDescription" is you pass to it "generator" or "description".

Mickael

[MGLorencin]

If you follow the links to the tracker you can see it was succesfully tested before I had a chance to post my own results.

From what I can see it has been committed to 1.5.7 because the bug appears to be gone in the latest version!!

Well I am on 1.5.7 and the bug is not gone in latest version, I have duplicate meta in all (but only in) articles, but not in front page, section or category view.

I even tried and run over with complete J1.5.7 and it didn's solve my issue until I installed SEO patch for 1.5.7 from joomlatwork.com ...really glad this solved it

[C0nw0nk]

Thanks for the information been searching everywhere for this can someone list it on the wiki also does this work with the latest version of joomla ?