[LOW:FIXED: 1.0.11] Bannerupload broken

[nico haase]

Description:
Bannerupload broken in Joomla 1.0.11. A direct upload through the button "upload" in the components toolbar is not possible because the popup re-sets the directory to ''.

Reported on:
1.0.11

Affected functions:
Bannerupload of com_banner

Related files:
administrator/popups/uploadimage.php

Steps to replicate:
Adminpanel, click components, banners, manage banners, upload. Try to upload an image and open it with the banner-management.

Proposed fix(es):
administrator/popup/uploadimage.php, line 75 following, change

Code: Select all

if ( $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
	$directory 	= '';
}

to

Code: Select all

if ( $directory != 'banners' && $directory != '' && !is_dir($mosConfig_absolute_path .'/images/stories/'. $directory)) {
	$directory 	= '';
}

System info:
Joomla! 1.0.11 Stable [ Sunbow ] 28 August 2006 20:00 UTC

[user deleted]

[TAGGED: Q&T] Status > Under Review

[infograf768]

What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php

[nico haase]

What I get here is uploading OK, but in images/stories instead of images/banners, although there is a check for images/banners in uploadimage.php

Yes, thats alright, I also get this. The check for directories is done before banners is described as a special case. So this second check always falses.

[infograf768]

@nico

I confirm your hack works. I don't know if it is asecurity problem though

[user deleted]

Bug tracker artifact added: http://forge.joomla.org/sf/go/artf5756?nav=1

[Predator]

Fixed in SVN

[user deleted]

Hi,

I will be updating all Q&T topics tomorrow. I will add fixes to the known issue list as well.

Regards Robin

[user deleted]

Artifact (http://forge.joomla.org/sf/go/artf5756?nav=1) has been fixed for next release, closing topic as FIXED, moving to Resolved.

[Jellocat]

I'm using  1.0.13 and the fix reported here above is in place in the uploadimage.php but it's still broken. When I try to upload a new image for a banner I get the following error:

Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator, [email protected] and inform them of the time the error occurred, and anything you might have done that may have caused the error.

More information about this error may be available in the server error log.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

I've chmoded the directories to 777 but that didn't help. Any ideas??

[user deleted]

Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.

[Jellocat]

Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.

Newbie here - how do I adjust the php memory?

[infograf768]

Internal errors could also mean you are running out of memory. I'ust up the php memory a bit and see if that solves it.

Newbie here - how do I adjust the php memory?

Is'nt it through php.ini ?

[cordelia]

php.ini:

In this section the runtime configuration parameters are examined in depth as far as phpWebSite is concerned.

Caution Note that setting the configuration parameters in the php.ini file will affect all the other php applications on the same server. A missconfiguration in one of these values will torpedo your whole site not to mention phpWebSite.

Warning As noted with the other two ways of making these changes you should only pick one of these and use it alone.