Is that really true? I answer all email that isn't about [* spam *]...I've tried contacting the developers of Vemod a couple of times so far, and after a couple of weeks I still haven't received a reply from them. I'll keep on trying though, it would definitely be great if they could give me a review.
Note to self: never drink coffee while reading.tha wrote: Is that really true? I answer all email that isn't about [* spam *]...
I am pretty sure that the language notices are normal. I tried to install other Joomla! 1.5 native components and I get the same notices.The component installs without problems. I assume that notices about language files that was not installed are just right.
I was a little confused about paths and urls and I now have fixed the $mosconfig_live_site problem.The tabs are rewritten to 1.5-tabs and the backend looks right. There seems to be a problem with the preview buttons and after a little debugging it appears that not all instances of $mosconfig_live_site and $mosconfig_sitename has been replaced with the new function calls required. What is also a problem is that $mosconfig_live_site should not be replaced with JPATH_BASE but with JURI::root().
It seems that I misunderstood the situation with the modules. For some odd reason I thought that the modules that weren't found were Vemod modules. But obviously I was very wrongAnother issue at the backend is that when the config is saved warnings about missing modules are displayed. This could have been a simple issue but unfortunately module files are not placed directly in the 'modules' directory in Joomla 1.5. The code that handles modules has to be rewritten to find the right path for each module. Since it seems that the name of the module directory is the same as the name of the module it could be done with $modulename . '/' . $modulename . '.php', which might (or might not) work with future modules?
. I fixed this as well.I haven't fixed the publish_up time yet, I will when I have time to take a closer look. For the Fatal Error, it seems that I converted every call to mosMail() but this one slipped throughNow it was time to create a news item and mail it away. The first small problem was that when a news item is created the publish_up time seems (by default in Joomla 1.5) to be set to the following whole hour (i.e. 12:00:00 when the news item was created 11:05:00). That might not be a problem but the news item won't show up on the preview page before 12:00:00.
Pressing the 'send' button at the preview page gives the following Fatal error: Call to undefined function mosMail() in I:\xampplite\htdocs\joomla15RC4\components\com_vemod_news_mailer\vemod_news_mailer.html.php on line 336
. Well I fixed this up so it should work now.When going through tests for undefined variables I only encountered one so far: Notice: Undefined variable: fromtemplate in /opt/lampp/htdocs/joomlanight/components/com_vemod_news_mailer/vemod_news_mailer.php on line 21. This variable is used a few times throughout vemod_news_mailer.php, however it is never defined. I wanted to check if it was a change I made that made it undefined, so I tried running the original Vemod component in Joomla! 1.0. However, I still got the same notice. I'm not quite sure how to handle this, nor the purpose of this variable.I also think that it is a good idea to turn notices on in php.ini while developing and testing to get rid of undefined variables and the like.
. I attached the revised component. I'm glad you appreciate it...Take have a look at line 1108-1114 in admin.vemod_news_mailer.php in the zip you attached. $mosconfig_live_site and $mosconfig_sitename are still there. If you switch on notices you will discover since "view source" in your browser will show notices instead of the expected strings.I was a little confused about paths and urls and I now have fixed the $mosconfig_live_site problem.
Well, I guess you can't without bribing the joomla developersI haven't fixed the publish_up time yet, I will when I have time to take a closer look.
There are still two calls to mosmail in vemod_news_mailer.html.php. If sending a newsletter works for you I suspect you are testing a component that is supposed to be native in legacy mode???For the Fatal Error, it seems that I converted every call to mosMail() but this one slipped through . Well I fixed this up so it should work now.
$fromtemplate is defined in the template file if you switch on scheduled mailings. And you are right! this notice comes up in version 1.2.3 of the 1.0.x componentWhen going through tests for undefined variables I only encountered one so far: Notice: Undefined variable: fromtemplate in /opt/lampp/htdocs/joomlanight/components/com_vemod_news_mailer/vemod_news_mailer.php on line 21. This variable is used a few times throughout vemod_news_mailer.php, however it is never defined. I wanted to check if it was a change I made that made it undefined, so I tried running the original Vemod component in Joomla! 1.0. However, I still got the same notice. I'm not quite sure how to handle this, nor the purpose of this variable.
which is why Code: Select all
if(!isset($fromtemplate)) $fromtemplate = 0;It is a good idea for each of our contestants to do this: set error_reporting = E_ALL in the php.ini file during development.tha wrote: I also think that it is a good idea to turn notices on in php.ini while developing and testing to get rid of undefined variables and the like.
. It looks like a lot of important changes were made in this version. Because of this, it would probably be much better if I focused all of the component changes on 1.2.4 instead of 1.2.3. This should take me only several days because I have a much better understanding of how this component works now, and the changes that need to be made between Joomla! 1.0 and Joomla! 1.5..Code: Select all
'<?php echo $sidebarmodule2." title"; ?>','<?php echo $sidebarmodule3." title"; ?>','<?php echo $sidebarmodule4." title"; ?>','<?php echo @$sidebarmodule5." title"; ?>','<?php echo @$sidebarmodule6." title"; ?>','Close','User Name',this.form.unsubscribealltext.value,this.form.compilednewsmailHTML.value,1)" value=" view ">
tha wrote: Actually I created a working version of 1.2.4 for joomla 1.5 today with the help of your code and a text compare program. It is going to be fun to compare our versions when you are ready
. Anyway this version appears to work, and doesn't have nearly as many silly mistakes as my Vemod 1.2.3 versions.Code: Select all
if (!file_exists(JPATH_SITE."/modules/" . $sidebarmodule3 . "/" . $sidebarmodule3 . ".php"))Code: Select all
if (file_exists(JPATH_SITE."/modules/" . $modulename . "/" . $modulename . ".php"))Code: Select all
include(JPATH_SITE."/modules/" . $modulename . "/" . $modulename . ".php");
. Much like you said Amy, I learned a lot during this task, and you can be sure that I will continue to contribute to the Joomla! community. I am going to upload this to google tomorrow after I make the changes Thomas noted in his previous post.. I'm going to make those changes and upload the component to google tomorrow. I really like your ideas about the read more link. However, I feel I really should post this component to google as soon as possible. I'm completely willing to work with you on Vemod outside of this competition of course . I hope we keep in touch. Finally, thank you very much for giving me guidance in this competition! You've helped a great deal.Sure, I wasn't asking you to implement it, I just wanted to hear your thoughts. There are many changes in Joomla 1.5 and some of them calls for a little extra creativity.I really like your ideas about the read more link. However, I feel I really should post this component to google as soon as possible.
Code: Select all
function vmn_getContentURL($newsitem)
{
global $mainframe;
$database = &JFactory::getDBO();
$Itemid = $mainframe->getItemid( $newsitem->id, 0, 0);
return vmn_sefRelToAbs("index.php?view=article&id=". $newsitem->id . "&option=com_content&Itemid=" . $Itemid);
}
Code: Select all
$now = date( 'Y-m-d H:i:s' );Code: Select all
$now = gmdate( 'Y-m-d H:i:s' );© 2005 - 2024 Open Source Matters, Inc. All Rights Reserved.
