Puzzled by this and still suspecting a change in the code, I have just compared the files of J!1.5.3 with those of J!1.5.9.
In 1.5.3 mod_login helper.php had this:
Code:
function getReturnURL($params, $type)
{
if($itemid = $params->get($type))
{
$menu =& JSite::getMenu();
$item = $menu->getItem($itemid);
$url = $item->link;
}
else
{
// Redirect to login
$uri = JFactory::getURI();
$url = $uri->toString();
}
return base64_encode($url);
}
In 1.5.9 this was changed to the following:
Code:
function getReturnURL($params, $type)
{
if($itemid = $params->get($type))
{
$menu =& JSite::getMenu();
$item = $menu->getItem($itemid);
$url = JRoute::_($item->link.'&Itemid='.$itemid, false);
}
else
{
$url = JURI::base(true);
}
return base64_encode($url);
}
I think the 1.5.3 lines marked by the comment "// Redirect to login" would redirect to the page where the login button was clicked, and I think JURI::base in 1.5.9 effectively means the front page.
If so, then indeed it was possible in the past not to set a redirection page so as to make users return to the previous page, whereas now there will always be redirection whether to the front page or, if and as set by the administrator, elsewhere.
Frankly, if this is not a bug it is certainly no improvement.
So, what I am going to do is to change my files as follows, and I hope 1.5.10 will have the same:
Code:
add in xml:
<param name="redirect" type="radio" default="0" label="Redirect" description="Redirect to home page or elsewhere as selected">
<option value="0">No</option>
<option value="1">Yes</option>
</param>
change in helper.php
function getReturnURL($params, $type)
{
$redirection = $params->get( 'redirect', 0 )
if ($redirection!=0)
{
if($itemid = $params->get($type))
{
$menu =& JSite::getMenu();
$item = $menu->getItem($itemid);
$url = JRoute::_($item->link.'&Itemid='.$itemid, false);
}
else
{
$url = JURI::base(true);
}
} else
{
// Redirect to login
$uri = JFactory::getURI();
$url = $uri->toString();
}
return base64_encode($url);
}
I have not tested it yet, but something like this should preserve the old functionality while adding the new functionality.
I'm sure it was removed for a reason, but it was really very necessary step to keep the website simple for clients to navigate.
